Conversation
Override logback version to 1.3.15 JIRA: LIGHTY-365 Signed-off-by: tobias.pobocik <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to update the Logback library version to "1.3.15" within the project. This is achieved by explicitly defining the "logback-classic" and "logback-core" dependencies in the "lighty-core/dependency-versions/pom.xml" file. This change ensures that the project uses the specified Logback version, potentially overriding an older version that might be brought in transitively by other dependencies.
Highlights
- Dependency Management: Explicitly added "logback-classic" and "logback-core" dependencies to the "lighty-core/dependency-versions/pom.xml" file.
- Version Bump: The version for both "logback-classic" and "logback-core" dependencies has been set to "1.3.15".
- Future Consideration: A "FIXME" comment has been added to indicate that these explicit overrides should be removed once ODL (OpenDaylight) itself updates to a newer logback version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request overrides the version of logback-classic and logback-core to 1.3.15 in the dependency-versions POM. This is a good change, likely to address security vulnerabilities in older versions. I've suggested an improvement to use the logback-bom for managing these dependencies, which aligns better with the existing practices in the file and improves maintainability.
| <!-- FIXME remove this when ODL bumps to newer logback version --> | ||
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.3.15</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-core</artifactId> | ||
| <version>1.3.15</version> | ||
| </dependency> |
There was a problem hiding this comment.
To improve maintainability and align with the common practice of using a Bill of Materials (BOM) in this file, consider using the logback-bom. This will manage the versions for all logback artifacts consistently and make future updates easier. This approach is already used for other dependencies like odlparent and junit-bom in this POM.
<!-- FIXME remove this when ODL bumps to newer logback version -->
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-bom</artifactId>
<version>1.3.15</version>
<type>pom</type>
<scope>import</scope>
</dependency>
2 participants
Override logback version to 1.3.15
JIRA: LIGHTY-365