Bump jetty to 9.4.58.v20250814#2335
Conversation
Override jetty version to 9.4.58.v20250814 JIRA: LIGHTY-365 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit 5151ff5) Signed-off-by: tobias.pobocik <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the Jetty server dependency to a specific newer version. The change involves directly overriding the Jetty version in the project's dependency management file. This update is likely aimed at addressing a known issue or incorporating critical fixes from the newer Jetty release, with a clear indication that this override is a temporary measure until upstream dependencies are aligned.
Highlights
- Jetty Version Override: Explicitly overrides the Jetty server dependency to version
9.4.58.v20250814within thelighty-core/dependency-versions/pom.xmlfile. - Temporary Override Indication: Introduces a
FIXMEcomment to highlight that this dependency override is temporary and should be removed once OpenDaylight (ODL) officially updates to a newer Jetty version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request overrides the Jetty version to 9.4.58.v20250814. While the intent to upgrade is correct, the current implementation only overrides the jetty-server artifact. This is risky as it can lead to version conflicts with other Jetty artifacts used throughout the project, potentially causing runtime issues. My review includes a suggestion to use the Jetty Bill of Materials (BOM) instead. This ensures that all Jetty-related dependencies are consistently aligned to the new version, which is a more robust and maintainable approach.
2 participants
Override jetty version to 9.4.58.v20250814
JIRA: LIGHTY-365
(cherry picked from commit 5151ff5)