Bump jetty to 9.4.58.v20250814#2334
Conversation
Override jetty version to 9.4.58.v20250814 JIRA: LIGHTY-365 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit 5151ff5)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to update the Jetty server dependency to version 9.4.58.v20250814. This is achieved by explicitly overriding the Jetty version in the project's pom.xml file. The change is noted as a temporary fix, intended to be reverted once a higher-level dependency (OpenDaylight) incorporates a newer Jetty version itself. This update addresses the JIRA ticket LIGHTY-365.
Highlights
- Jetty Version Override: The pull request explicitly sets the
jetty-serverdependency version to9.4.58.v20250814within thedependencyManagementsection oflighty-core/dependency-versions/pom.xml. - Temporary Dependency Management: This change includes a
FIXMEcomment, indicating that this dependency override is a temporary measure intended to be removed once the upstream OpenDaylight (ODL) project updates its own Jetty dependency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request overrides the version of jetty-server to 9.4.58.v20250814, which is a necessary step to manage dependencies. However, the current implementation only overrides a single Jetty artifact, which could lead to version conflicts with other Jetty dependencies used in the project (e.g., http2-server, jetty-alpn-server). This can cause runtime errors. My review includes a suggestion to use the Jetty Bill of Materials (BOM) to ensure all Jetty dependencies are consistently versioned, which is a more robust and maintainable approach.
| <dependency> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-server</artifactId> | ||
| <version>9.4.58.v20250814</version> | ||
| </dependency> |
There was a problem hiding this comment.
Overriding only the jetty-server dependency can lead to version mismatches with other Jetty artifacts used in the project, such as http2-server, jetty-alpn-server, and jetty-alpn-java-server. This can cause difficult-to-debug runtime issues like NoSuchMethodError.
To ensure all related Jetty dependencies use the same version, it is a best practice to import the Jetty Bill of Materials (BOM). This will manage the versions for all Jetty artifacts consistently.
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-bom</artifactId>
<version>9.4.58.v20250814</version>
<type>pom</type>
<scope>import</scope>
</dependency>
2 participants
Override jetty version to 9.4.58.v20250814
JIRA: LIGHTY-365
(cherry picked from commit 5151ff5)