Skip to content

Comments

Bump jetty to 9.4.58.v20250814#2333

Merged
ihrasko merged 1 commit intoPANTHEONtech:mainfrom
Tobianas:mainBumpJetty
Aug 28, 2025
Merged

Bump jetty to 9.4.58.v20250814#2333
ihrasko merged 1 commit intoPANTHEONtech:mainfrom
Tobianas:mainBumpJetty

Conversation

@Tobianas
Copy link
Contributor

Override jetty version to 9.4.58.v20250814

JIRA: LIGHTY-365

Override jetty version to 9.4.58.v20250814

JIRA: LIGHTY-365
Signed-off-by: tobias.pobocik <[email protected]>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the version of the Jetty server dependency to 9.4.58.v20250814 within the lighty-core module. This change explicitly overrides the Jetty version in the project's dependency management to ensure a specific, newer version is used.

Highlights

  • Dependency Update: The Jetty server dependency is bumped to version 9.4.58.v20250814.
  • Explicit Override: The new Jetty version is added to the dependencyManagement section of lighty-core/dependency-versions/pom.xml, ensuring this specific version is used across the project.
  • Temporary Fix: A FIXME comment indicates that this override is a temporary measure and should be removed once the upstream OpenDaylight (ODL) project updates its own Jetty dependency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request overrides the Jetty version to 9.4.58.v20250814. This is a straightforward change to manage a transitive dependency version, and the use of <dependencyManagement> is appropriate. The FIXME comment provides helpful context. I have one suggestion to improve the comment for better future traceability.

@ihrasko ihrasko merged commit 5151ff5 into PANTHEONtech:main Aug 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants