21.X Bump third party dependencies#2290
Conversation
https://github.com/testng-team/testng/releases/tag/7.11.0 JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit 1d93077)
https://github.com/skyscreamer/JSONassert/releases/tag/jsonassert-1.5.3 JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit 624732b)
https://docs.junit.org/snapshot/release-notes/index.html#release-notes-5.13.4 JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit b4c83cb)
https://commons.apache.org/proper/commons-io/changes.html#a2.20.0 JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit 5a9a34c)
https://github.com/stleary/JSON-java/releases/tag/20250517 JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit d6e3d93)
https://github.com/apache/maven-gpg-plugin/releases/tag/maven-gpg-plugin-3.2.8 JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit db48865)
https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.6.1 JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit 6d69020)
JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit e5bc63d)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating a range of third-party dependencies and Maven plugins used across the project. The primary goal is to bring these components up to their latest stable versions, which typically includes bug fixes, performance improvements, security patches, and new features from the upstream projects. This ensures the project benefits from the most recent advancements and maintains compatibility with evolving ecosystems.
Highlights
- Dependency Updates: Updated several core testing and utility dependencies, including
testngfrom7.10.2to7.11.0,jsonassertfrom1.5.1to1.5.3,junit-bomfrom5.12.1to5.13.4,commons-iofrom2.19.0to2.20.0, andorg.jsonfrom20240303to20250517. - Maven Plugin Upgrades: Upgraded multiple Maven plugins across various
pom.xmlfiles, specificallymaven-gpg-pluginfrom3.2.7to3.2.8,maven-enforcer-pluginfrom3.5.0to3.6.1, andlicense-maven-pluginfrom4.1to5.0.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates several third-party dependencies and Maven plugins across multiple pom.xml files. While most updates seem correct, I've identified three version updates that point to non-existent artifacts in public Maven repositories. These will likely cause build failures and need to be corrected. Please see the detailed comments below.
| <groupId>org.junit</groupId> | ||
| <artifactId>junit-bom</artifactId> | ||
| <version>5.12.1</version> | ||
| <version>5.13.4</version> |
There was a problem hiding this comment.
The version for org.junit:junit-bom is set to 5.13.4, which does not appear to be a publicly available version. The latest version on Maven Central is 5.10.2. Using a non-existent version will cause dependency resolution to fail. Please verify that this version is correct and accessible from your build environment.
2 participants
No description provided.