Fix inconsistent dependency versions#2279
Conversation
Use the versions which are in dependency-versions across the entire project. Signed-off-by: tobias.pobocik <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to improve project consistency by updating several dependency versions to align with the centrally defined dependency-versions across the project. This ensures that the build process uses standardized and up-to-date versions for key tools and plugins.
Highlights
- Dependency Version Updates: Updated
yang-maven-pluginand itsbinding-codegendependency from version14.0.11to14.0.14inlighty-core/lighty-binding-parent/pom.xml. - Tooling Version Updates: Updated
checkstyleandspotbugsplugin dependency versions from14.0.8to14.1.0inlighty-core/lighty-parent/pom.xml.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to fix inconsistent dependency versions by updating them across different pom.xml files. The changes correctly update the versions. However, to better align with the goal of consistency and improve long-term maintainability, I've suggested using Maven properties to centralize these version numbers. This would involve defining properties in a central location like dependency-versions/pom.xml and referencing them where needed, which avoids hardcoding versions in multiple places.
| <groupId>org.opendaylight.odlparent</groupId> | ||
| <artifactId>checkstyle</artifactId> | ||
| <version>14.0.8</version> | ||
| <version>14.1.0</version> |
There was a problem hiding this comment.
To centralize version management as stated in the PR description, it's better to use a property for this version. Since the spotbugs dependency is also updated to the same version, a single property like odlparent.version could be defined in dependency-versions/pom.xml and used in both places.
<version>${odlparent.version}</version>
2 participants
Use the versions which are in dependency-versions across the entire project.