Manage RNC and RCGNMI docker artifacts by maven-release-plugin#2272
Manage RNC and RCGNMI docker artifacts by maven-release-plugin#2272ihrasko merged 3 commits intoPANTHEONtech:20.xfrom
Conversation
lighty-controller-springboot-netconf does not inherit SCM tag, add it explicitly. Add developers and licenses sections as well. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit e5a8a4e)
Add lighty-rnc-app-docker and lighty-rcgnmi-app-docker to excluded artifacts for maven central publish plugin. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit cf7a87f)
Skip deployment phase for lighty-rnc-app-docker and lighty-rcgnmi-app-docker artifacts. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit 7b20465)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ihrasko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to streamline the release process for the RNC and RCGNMI Docker applications by integrating them more effectively with the maven-release-plugin. The changes enable a simplified, automated release workflow for these Docker artifacts, reducing manual steps and ensuring consistency in the release pipeline.
Highlights
- Streamlined Docker Artifact Release: Configured
lighty-rcgnmi-app-dockerandlighty-rnc-app-dockermodules to be managed by themaven-release-plugin, allowing for automated release preparation and performance via standard Maven commands. - Maven Deployment Exclusion: Set
maven.deploy.skiptotruein thepom.xmlfiles forlighty-rcgnmi-app-dockerandlighty-rnc-app-dockerto prevent these Docker-specific modules from being deployed as standard Maven artifacts. - Release Plugin Artifact Exclusion: Updated the
lighty-minimal-parentPOM to explicitly exclude thelighty-rcgnmi-app-dockerandlighty-rnc-app-dockerartifacts from themaven-release-plugin's default artifact management, ensuring their lifecycle is handled appropriately for Docker images. - Project Metadata Enhancement: Added comprehensive project metadata, including license, SCM details, and developer information, to
lighty-controller-springboot-netconf/pom.xml, which is crucial for proper project release and distribution.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enables the use of the maven-release-plugin for RNC and RCGNMI docker artifacts. It configures the docker packaging modules to be skipped during deployment and excluded from publishing to Maven Central. Additionally, it adds SCM information to an example module, which is necessary for the release plugin to function across the entire project.
1 participant
This patch enables us to prepare release with just (+ adjusting documentation and READMEs):