Manage RNC and RCGNMI docker artifacts by maven-release-plugin#2271
Manage RNC and RCGNMI docker artifacts by maven-release-plugin#2271ihrasko merged 3 commits intoPANTHEONtech:21.xfrom
Conversation
lighty-controller-springboot-netconf does not inherit SCM tag, add it explicitly. Add developers and licenses sections as well. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit e5a8a4e)
Add lighty-rnc-app-docker and lighty-rcgnmi-app-docker to excluded artifacts for maven central publish plugin. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit cf7a87f)
Skip deployment phase for lighty-rnc-app-docker and lighty-rcgnmi-app-docker artifacts. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit 7b20465)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ihrasko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on streamlining and automating the release process for the RNC and RCGNMI Docker artifacts by integrating them more tightly with the maven-release-plugin. The changes aim to simplify the steps required to prepare and perform a release, ensuring a more consistent and efficient build pipeline. Additionally, it includes updates to project metadata for one of the example modules.
Highlights
- Maven Deployment Configuration: Skipped standard Maven deployment for the
lighty-rcgnmi-app-dockerandlighty-rnc-app-dockermodules by settingmaven.deploy.skiptotruein their respectivepom.xmlfiles. This change ensures that themaven-release-pluginor a specific release profile will manage the deployment of these Docker artifacts. - Maven Release Plugin Configuration: Updated the
lighty-minimal-parent/pom.xmlto explicitly includelighty-rcgnmi-app-dockerandlighty-rnc-app-dockerin theexcludeArtifactslist for themaven-release-plugin. This indicates that these specific Docker modules are now managed by a dedicated release mechanism, likely via thedockerprofile, rather than the parent's default release process. - Project Metadata Enhancement: Added comprehensive project metadata, including license information (Eclipse Public License 1.0), Source Code Management (SCM) details pointing to the GitHub repository, and developer information, to the
lighty-controller-springboot-netconf/pom.xml. This is typically done to prepare a module for publication to public Maven repositories.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the Maven configuration to properly handle Docker artifacts for RNC and RCGNMI applications during the release process. This is achieved by skipping Maven deployment for the Docker modules and excluding them from publication to Central. Additionally, it adds necessary SCM and license metadata to an example module's POM, likely to satisfy maven-release-plugin requirements. The changes are logical and well-aligned with the PR's goal.
1 participant
This patch enables us to prepare release with just (+ adjusting documentation and READMEs):