Fix Minikube setup on GitHub Actions#2209
Merged
ihrasko merged 2 commits intoPANTHEONtech:mainfrom May 23, 2025
Merged
Conversation
Tobianas
force-pushed
the
fix_actions
branch
6 times, most recently
from
870e343 to
e38b3a4
Compare
Tobianas
changed the title
Tobianas
force-pushed
the
fix_actions
branch
23 times, most recently
from
f17e3db to
d39507b
Compare
Tobianas
force-pushed
the
fix_actions
branch
8 times, most recently
from
d0702de to
4dc9e98
Compare
Collaborator
|
/gemini review |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Tobianas
force-pushed
the
fix_actions
branch
6 times, most recently
from
edc8757 to
2b3a3c5
Compare
ihrasko
requested changes
May 23, 2025
Update the Dockerfile to use JSON array syntax to ensure the entrypoint works properly. Also use uppercase AS and FROM to resolve warnings. https://hackernoon.com/fix-dockerfile-error-warn-fromascasing-as-and-from-keywords-casing-do-not-match https://docs.docker.com/reference/build-checks/json-args-recommended/ This resolves previous issues where Controller could not connect to simulator. JIRA: LIGHTY-367 Signed-off-by: tobias.pobocik <[email protected]>
Running netconf-simulator using docker while running controller using kubernetes created all sorts of networking separation issues. Running both of them using kubernetes makes the code more robust and reduces the chance of experiencing networking separation issues. JIRA: LIGHTY-367 Signed-off-by: tobias.pobocik <[email protected]>
ihrasko
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.