Deprecate LightyModule#startBlocking#2046
Merged
ihrasko merged 1 commit intoPANTHEONtech:21.xfrom Oct 30, 2024
Merged
Conversation
Deparecate practically unused LightyModule#startBlocking method which helps us to get rid of CountDownLatch in AbstractLightyModule. This method seems to be mixing concepts of using Future and CountDownLatch synchronisation tools. IMO there is no need to block start method. Additionally, there were some unusual usages in tests. They were trying to invoke a blocking call and wrap its result into Future. JIRA: LIGHTY-299 Signed-off-by: Ivan Hrasko <[email protected]> (cherry picked from commit 187f7f6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deparecate practically unused LightyModule#startBlocking method which helps us to get rid of CountDownLatch in AbstractLightyModule.
This method seems to be mixing concepts of using Future and CountDownLatch synchronisation tools. IMO there is no need to block start method.
Additionally, there were some unusual usages in tests. They were trying to invoke a blocking call and wrap its result into Future.
JIRA: LIGHTY-299
Signed-off-by: Ivan Hrasko [email protected]
(cherry picked from commit 187f7f6)