Skip to content

feat: add sidebar hover preview - #4661

Closed
Rishet11 wants to merge 1 commit into
mainfrom
ao/agent-orchestrator-239/root
Closed

feat: add sidebar hover preview#4661
Rishet11 wants to merge 1 commit into
mainfrom
ao/agent-orchestrator-239/root

Conversation

@Rishet11

@Rishet11 Rishet11 commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a 250 ms far-left edge dwell that temporarily opens collapsed adaptive and off-canvas sidebars without changing the main-content layout.
  • Open the same temporary overlay immediately from the actual titlebar sidebar button, with stable trigger and logical sidebar pointer zones to support trigger-to-sidebar transfer.
  • Keep temporary dismissal at 55 ms, preserve click-to-pin and Cmd/Ctrl+B keyboard pinning, and reject touch, drag, and text-selection activation.
  • Add a short reduced-motion-safe reveal and hide transition while preserving pinned-sidebar behavior and layout gaps.

Coverage

  • Focused Sidebar, titlebar, Linux titlebar, Windows titlebar, and shell tests cover adaptive/off-canvas peek, pinning, stable hover zones, dismissal, and accessibility behavior.
  • No automated AO Browser verification was performed.

Closes #4647

Copilot AI lite review requested due to automatic review settings August 30, 2026 07:56
Copilot AI reviewed Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rishet11

Rishet11 commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator Author
Screen.Recording.2026-08-30.at.1.35.11.pm.mov

Vaibhaav-Tiwari
Vaibhaav-Tiwari requested changes Aug 30, 2026
View reviewed changes

@Vaibhaav-Tiwari Vaibhaav-Tiwari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

  1. The new useRef and useEffect hooks in components/ui/sidebar.tsx
    are placed after conditional returns. Resizing across the mobile
    breakpoint—or starting with a narrow window—can change the hook
    count and crash React. Please move all hooks above the
    conditional returns and add a responsive-resize test.

  2. The temporary sidebar uses z-chrome (z-10), while the Archive
    panel uses z-20. As a result, the Archive bar renders over the
    sidebar preview. Please ensure the temporary sidebar is above
    board overlays while remaining below dialogs/titlebar elements,
    and add coverage for this case.

  3. Adaptive/icon-mode preview still snaps between the compact rail
    and expanded sidebar. Only off-canvas mode receives the new
    opacity/transform transition. Please add a proper reduced-motion-
    safe open/close transition for icon mode.

ronishrohan
ronishrohan requested changes Aug 30, 2026
View reviewed changes

@ronishrohan ronishrohan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature already existed in the past, was removed due to certain reasons, getting in touch with you for details

@Annieeeee11

Annieeeee11 commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

feature already existed in the past, was removed due to certain reasons, getting in touch with you for details

Yes also we really don't need it

@Rishet11 Rishet11 closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@ronishrohan ronishrohan ronishrohan requested changes
@Vaibhaav-Tiwari Vaibhaav-Tiwari Vaibhaav-Tiwari requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(desktop): reveal the collapsed sidebar after a pointer dwell at the left edge

5 participants

@Rishet11 @Annieeeee11 @ronishrohan @Vaibhaav-Tiwari