#8839 Orchard Layouts Bootstrap 4 columns fix#8840
Merged
BenedekFarkas merged 5 commits intoSep 26, 2025
Merged
Conversation
… col-* to fix columns. col-xs-* was removed in Bootstrap 4. display:flex was also added to Row.less to counteract the display:block on all the divs between .row and the .col-*
…rt of the Bootstrap 3 source which is not used anymore.
Contributor
Author
|
The display:flex rule is causing issues and will need more specificity. Update coming. |
sebastienros
approved these changes
Sep 11, 2025
Member
|
The client-side asset build pipeline (with Gulp) is supposed to be working, but you need to use Node v7 (I know, ancient) for it. Unfortunately, I just noticed that the workflow job that checks the integrity of the client-side assets is broken, so I'll fix that first and then review this PR. |
…f multiple elements were in a column, they were displaying horizontally instead of vertically. In order to fix this and manage situations where there are nested rows, the CSS specification had to be high.
Contributor
Author
|
Per my previous comment, there were some issues in the editor. I added a new commit that fixes the display of rows / columns and child elements. |
BenedekFarkas
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8839 update all col-xs-* in Orchard.Layouts module to just col-* to fix columns. col-xs-* was removed in Bootstrap 4. display:flex was also added to Row.less to counteract the display:block on all the divs between .row and the .col-*
Gulp is broken per #8522 so all compiled files were manually updated. These files are included in the source, so this should work just fine.