Added flag to display a single model error for MediaLibraryPickerField#8700
Merged
MatteoPiovanelli merged 2 commits intoJun 30, 2023
Merged
Conversation
…media have been removed from the field only. This ensures that no duplicate model error has displayed.
Contributor
Author
|
Hi @sebastienros |
| mediaItem.As<MediaPart>().FileName)); | ||
| } | ||
| else { | ||
| } else { |
Member
There was a problem hiding this comment.
nit: that's not how it should be formatted, it was fine on a separate line
sebastienros
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added flag to display a single model error by LocalizationExtensionHandler if media have been removed from the field only. This ensures that no duplicate model error has displayed.
The flag is true when the field is set to remove items without localization and one or more media items cannot be localized.
Afterwards, to display a model error, this flag is checked in combination with the previously implemented checks (if field is required and any media item is selected).