localizationpartdriver refactor#8366
Merged
sebastienros merged 2 commits intoMay 7, 2020
Merged
Conversation
Prevent driver from repeating the same query several times in a request (it used to try and fetch all of a part's localizations at least twice per request). Changed query for a MasterContentItem's localizations so it should "hint" sql to use different indexes. # Conflicts: # src/Orchard.Web/Modules/Orchard.Localization/Services/LocalizationService.cs
Avoid some calls for translation groups when we know them to be empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #8365
What I briefly discussed there is implemented here as changes to LocalizationPartDriver.