Skip to content

It makes images recognizable in the admin even if they are white over a transparent background#8329

Merged
sebastienros merged 2 commits into
OrchardCMS:1.10.xfrom
LaserSrl:fix/8328_not_recognizable_media
Mar 5, 2020
Merged

It makes images recognizable in the admin even if they are white over a transparent background#8329
sebastienros merged 2 commits into
OrchardCMS:1.10.xfrom
LaserSrl:fix/8328_not_recognizable_media

Conversation

@HermesSbicego-Laser

@HermesSbicego-Laser HermesSbicego-Laser commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

fixes #8328, adding in the admin a white/grey squares background to containers of media of type "image"
Before
before-download

After
download

@sebastienros

Copy link
Copy Markdown
Member

Why not use a static file instead so it doesn't have to be duplicated in the css?
It's not a huge issue, just a suggestion.

@HermesSbicego-Laser

Copy link
Copy Markdown
Contributor Author

Intead of base64? It was just for consistency with other images used in that css... I will change it...

@sebastienros

Copy link
Copy Markdown
Member

No it's ok then

@sebastienros

Copy link
Copy Markdown
Member

No, it's ok then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants