Remove newly added terms before processing#8312
Merged
Merged
Conversation
`// Remove the newly added terms because they will get processed by the Published-Event
termList.RemoveAll(t => t.Term.Id == term.Id);`
This line on 284 of the TaxonomyService claims to remove newly added terms, because they will be processed by their own published event anyway. I don't think it's currently doing that however, since it's comparing the id of the TermPart to the id of the TermContentItem record. This is unlikely to cause any issues besides some overhead, but there is a theoretical edge case where a TermContentItem could have the same id as an existing term, causing that term not to be processed at all.
I believe this is what was intended:
`termList.RemoveAll(t => t.Term.TermRecord.Id == term.Id);`
MatteoPiovanelli
approved these changes
Jan 23, 2020
MatteoPiovanelli
left a comment
MatteoPiovanelli
left a comment
Contributor
There was a problem hiding this comment.
I think this is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// Remove the newly added terms because they will get processed by the Published-Event termList.RemoveAll(t => t.Term.Id == term.Id);This code on line 284 of the TaxonomyService claims to remove newly added terms, because they will be processed by their own published event anyway. I don't think it's currently doing that however, since it's comparing the id of the TermPart to the id of the TermContentItem record. This is unlikely to cause any issues besides some overhead, but there is a theoretical edge case where a TermContentItem could have the same id as an existing term, causing that term not to update.
I believe this is what was intended:
termList.RemoveAll(t => t.Term.TermRecord.Id == term.Id);