Making messages of register.cshtml consistent with the User settings#8301
Merged
sebastienros merged 4 commits intoDec 19, 2019
Merged
Conversation
| var requirementsMessage = T.Plural("The password can't be empty", "Passwords are required to be a minimum of {0} characters in length", (int)ViewData["PasswordLength"]).Text; | ||
| var additionalRequirementsMessage = new List<string>(); | ||
| if ((bool)ViewData["LowercaseRequirement"]) { | ||
| additionalRequirementsMessage.Add(T("one lowercase letter").Text); |
Member
There was a problem hiding this comment.
Can you ensure the Text property is not html encoded, otherwise it would result in double encoding in the output. To try it just replace some text with html, it should be encoded only once.
Contributor
Author
There was a problem hiding this comment.
I can confirm that T("").Text does not html encode the string.
Contributor
Author
There was a problem hiding this comment.
Looking better into the code I noticed we need to have similar changes somewhere else.
I will integrate this PR soon.
Contributor
Author
There was a problem hiding this comment.
Done with 2 new commits
Member
|
LGTM as long as there is no double encoding |
Contributor
Author
|
It should be good to be merged in dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8300