Issue/8284#8289
Conversation
|
LGTM @BenedekFarkas are you ok with it? If you don't answer I will merge myself. |
|
I was thinking about this PR earlier under the shower and I think I am not correctly handling the dashboard/backoffice menu. I should add an evict on enable/disable of a feature, but I am not sure that would be enough. |
|
Regarding admin side menus:
However, AdminMenuPart does not cause an update of that value. That means there is at least this one case that is not handled. I have to assume there will be more. |
|
I merged this fix into my project it dramatically improved the speed of the Admin side of the site. Thanks so much for this! The slowness was driving me nuts. |
|
I found some issues with the approach we took for caching frontend menu items. In summary: The other changes (caching of SslSettingPart and SiteSelector) still stand. |
9423485 to
dd5a387
Compare
| } | ||
|
|
||
| private void Invalidate(SslSettingsPart content) { | ||
| _signals.Trigger($"SslSettingsPart_{content.Id}"); |
There was a problem hiding this comment.
I will keep it but I think it's not necessary. And I don't see it used anywhere else either.
Fixes #8284
Tested locally Starting off Orchard 1.10.x as well as on our custom configuration.
The changes to
NavigationManagerimprove performances on menu-heavy frontends, as well as a little bit on the backoffice (because they also cache some of the operations that are done for the admin menu there)The other changes can really only be measured when serving cached content, as those operations are not that relevant compared to those required to generate frontend views. When serving stuff out of cache however those changes combined gave around 30% quicker responses on my a couple different test configurations.