Merge DraftFieldIndexService.cs into FieldIndexService.cs #7925 (Lombiq Technologies: ORCH-199)#8205
Merged
Merged
Conversation
Member
|
LGTM |
BenedekFarkas
requested changes
May 18, 2019
Member
There was a problem hiding this comment.
@domonkosgabor please make the following changes:
- Change the if-else structures to switch-case in FieldIndexService. Since FieldIndexRecordVersionOptions is an enum, we could support further values (for example QueryVersionScope supports Draft-only too).
- Simplify the return statements, as they duplicate a lot of code between the case execution paths.
- Also apply any code lens recommendations (e.g. "string" instead of "String"), including C# 7 language features.
- Resolve the merge conflict.
# Conflicts: # src/Orchard.Web/Modules/Orchard.Projections/Orchard.Projections.csproj
Simplify the return statements;
# Conflicts: # src/Orchard.Web/Modules/Orchard.Projections/Orchard.Projections.csproj
BenedekFarkas
approved these changes
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.