fix #7814 and 8091: update Newtonsoft.Json, Microsoft.Owin, IdentityModel to latest#8087
Merged
Conversation
updating Newtonsoft.Json to the latest version caused many other modifications to project files and web.config files throughout the solution. Separated these modifications out from the Newtonsoft.Json update to isolate the commits. Changes include: - removing `<private>true</private>` from assembly references as this is the default value and not included by default since many moons ago. - adding several missing binding redirects - revising project includion of packages.config from Content type to the proper None type - relocating `<system.codedom>` to the end of the Web.config, the default location that the block is injected by its NuGet pkg. - adding missing `EnsureNuGetPackageBuildImports` target These changes are regenerated, reformatted, or reformatted by NuGet updates. References OrchardCMS#7814
jayharris
changed the title
Contributor
Author
|
Revised this PR to also include updates to Microsoft.Owin., Microsoft.IdentityModel., and System.IdentityModel.*. There are several opportunities that open up, particularly with |
Member
|
Fixes #8091 |
csutorasr
pushed a commit
to csutorasr/Orchard
that referenced
this pull request
Aug 10, 2018
MatteoPiovanelli
pushed a commit
to LaserSrl/Orchard
that referenced
this pull request
May 17, 2019
…ardCMS#8087) # Conflicts: # src/Orchard.Azure.Tests/App.config # src/Orchard.Azure.Tests/Orchard.Azure.Tests.csproj # src/Orchard.Azure.Tests/packages.config # src/Orchard.Core.Tests/Orchard.Core.Tests.csproj # src/Orchard.Specs/App.Config # src/Orchard.Specs/Hosting/Orchard.Web/Web.config # src/Orchard.Tests.Modules/packages.config # src/Orchard.Tests/packages.config # src/Orchard.Web/Core/Orchard.Core.csproj # src/Orchard.Web/Modules/Orchard.Azure/Orchard.Azure.csproj # src/Orchard.Web/Modules/Orchard.CustomForms/Orchard.CustomForms.csproj # src/Orchard.Web/Modules/Orchard.DynamicForms/Orchard.DynamicForms.csproj # src/Orchard.Web/Modules/Orchard.Glimpse/Orchard.Glimpse.csproj # src/Orchard.Web/Modules/Orchard.Glimpse/Web.config # src/Orchard.Web/Modules/Orchard.MediaPicker/Orchard.MediaPicker.csproj # src/Orchard.Web/Modules/Orchard.OpenId/Orchard.OpenId.csproj # src/Orchard.Web/Modules/Orchard.OpenId/Web.config # src/Orchard.Web/Modules/Orchard.OpenId/packages.config # src/Orchard.Web/Modules/Orchard.OutputCache/Orchard.OutputCache.csproj # src/Orchard.Web/Modules/Orchard.Projections/Tests/Orchard.Projections.Tests.csproj # src/Orchard.Web/Modules/Orchard.Resources/Orchard.Resources.csproj # src/Orchard.Web/Modules/Orchard.Rules/Orchard.Rules.csproj # src/Orchard.Web/Modules/Orchard.SecureSocketsLayer/Orchard.SecureSocketsLayer.csproj # src/Orchard.Web/Modules/Orchard.SecureSocketsLayer/packages.config # src/Orchard.Web/Orchard.Web.csproj # src/Orchard.Web/Web.config # src/Orchard.Web/packages.config # src/Orchard/Orchard.Framework.csproj # src/Orchard/packages.config # src/Tools/Orchard.Tests/Orchard.Tests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Newtonsoft.Json to the latest version. Doing so also caused several other modifications to project files and web.config files throughout the solution.
Updating Newtonsoft.Json will also open the doors for a few other NuGet package updates, and some enhancements to the OpenId module, since most of the newer OpenIdConnect and Microsoft.IdentityModel packages require Newtonsoft.Json >= 10.
Automatically-Generated Changes include:
<private>true</private>from assembly references asthis is the default value and not included by default since many
moons ago.
Contenttypeto the proper
Nonetype<system.codedom>to the end of the Web.config, thedefault location that the block is injected by its NuGet pkg.
EnsureNuGetPackageBuildImportstargetsThese changes are regenerated, reformatted, or reformatted by
NuGet updates and not done by hand.
Fixes #7814