5408: Dropping static view compilation temporarily to be able support Dynamic Compilation with Roslyn#7892
Conversation
…ic Compilation support
…they don't have any Razor templates
…otNetCompilerPlatform.dll
…files from each module's bin folder
(cherry picked from commit 48685b3)
|
I believe you are still trying to find a better solution, that might involve fixing the codedomprovider library. |
|
Yep, already have a proof of concept with a "hacked" piece of code, but I think I'm close to a nice (extensible) solution. |
…pilerPlatform Provider
…g as the latest improvements
|
Blocked on the CodeDomProvider PR to be accepted |
|
What if a module doesn't have this Is it breaking existing modules from the gallery? Or the ones you'd have in your project? |
|
Can you revert the previous change that is breaking 1.10.x in the meantime, and work on a PR that provides all the changes? |
When writing C# 6 or above code in a Razor template in a module that doesn't have this configured, you'll see an error indicating that those language features are not available (but Razor IntelliSense is still operational), which is the same behavior as before. But it's OK in runtime, because Orchard.Web is responsible for that (just like with Dynamic Compilation). I'll go for a test run in Azure with this, but it looks OK locally.
So we should revert what exactly? I'm asking because the current problem is Roslyn Dynamic Compilation vs. Static View Compilation (with the current CodeDomProvider package). We can safely release with one of them, but not both (without the CodeDomProvider fix). I'd vote for Roslyn Dynamic Compilation. |
|
Merge what you think is right as long as it's not breaking existing modules from the gallery, and we don't require symlinks. |
…ic view compilation
…ted NuGet packages
…CompilerPlatform with metadata
BenedekFarkas
changed the title
… Dynamic Compilation with Roslyn (OrchardCMS#7892) # Conflicts: # ClickToBuild.cmd # Orchard.proj # src/Orchard.Web/Core/packages.config # src/Orchard.Web/Modules/Lucene/packages.config # src/Orchard.Web/Modules/Markdown/packages.config # src/Orchard.Web/Modules/Orchard.Alias/packages.config # src/Orchard.Web/Modules/Orchard.AntiSpam/packages.config # src/Orchard.Web/Modules/Orchard.ArchiveLater/packages.config # src/Orchard.Web/Modules/Orchard.AuditTrail/packages.config # src/Orchard.Web/Modules/Orchard.Autoroute/packages.config # src/Orchard.Web/Modules/Orchard.Azure.MediaServices/packages.config # src/Orchard.Web/Modules/Orchard.Blogs/packages.config # src/Orchard.Web/Modules/Orchard.Comments/packages.config # src/Orchard.Web/Modules/Orchard.ContentPermissions/packages.config # src/Orchard.Web/Modules/Orchard.ContentPicker/packages.config # src/Orchard.Web/Modules/Orchard.ContentTypes/packages.config # src/Orchard.Web/Modules/Orchard.CustomForms/packages.config # src/Orchard.Web/Modules/Orchard.Dashboards/packages.config # src/Orchard.Web/Modules/Orchard.DesignerTools/packages.config # src/Orchard.Web/Modules/Orchard.DynamicForms/packages.config # src/Orchard.Web/Modules/Orchard.Email/packages.config # src/Orchard.Web/Modules/Orchard.Fields/packages.config # src/Orchard.Web/Modules/Orchard.ImageEditor/packages.config # src/Orchard.Web/Modules/Orchard.ImportExport/packages.config # src/Orchard.Web/Modules/Orchard.Indexing/packages.config # src/Orchard.Web/Modules/Orchard.JobsQueue/packages.config # src/Orchard.Web/Modules/Orchard.Layouts/packages.config # src/Orchard.Web/Modules/Orchard.Lists/packages.config # src/Orchard.Web/Modules/Orchard.Localization/packages.config # src/Orchard.Web/Modules/Orchard.Media/packages.config # src/Orchard.Web/Modules/Orchard.MediaLibrary/packages.config # src/Orchard.Web/Modules/Orchard.MediaPicker/packages.config # src/Orchard.Web/Modules/Orchard.MediaProcessing/packages.config # src/Orchard.Web/Modules/Orchard.Modules/packages.config # src/Orchard.Web/Modules/Orchard.MultiTenancy/packages.config # src/Orchard.Web/Modules/Orchard.OutputCache/packages.config # src/Orchard.Web/Modules/Orchard.Packaging/packages.config # src/Orchard.Web/Modules/Orchard.Projections/packages.config # src/Orchard.Web/Modules/Orchard.PublishLater/packages.config # src/Orchard.Web/Modules/Orchard.Recipes/packages.config # src/Orchard.Web/Modules/Orchard.Resources/packages.config # src/Orchard.Web/Modules/Orchard.Roles/packages.config # src/Orchard.Web/Modules/Orchard.Rules/packages.config # src/Orchard.Web/Modules/Orchard.Scripting.CSharp/packages.config # src/Orchard.Web/Modules/Orchard.Search/packages.config # src/Orchard.Web/Modules/Orchard.SecureSocketsLayer/packages.config # src/Orchard.Web/Modules/Orchard.Setup/packages.config # src/Orchard.Web/Modules/Orchard.Tags/packages.config # src/Orchard.Web/Modules/Orchard.Taxonomies/packages.config # src/Orchard.Web/Modules/Orchard.Templates/packages.config # src/Orchard.Web/Modules/Orchard.Themes/packages.config # src/Orchard.Web/Modules/Orchard.Tokens/packages.config # src/Orchard.Web/Modules/Orchard.Users/packages.config # src/Orchard.Web/Modules/Orchard.Warmup/packages.config # src/Orchard.Web/Modules/Orchard.Widgets/packages.config # src/Orchard.Web/Modules/Orchard.Workflows/packages.config # src/Orchard.Web/Modules/Orchard.jQuery/packages.config # src/Orchard.Web/Modules/TinyMce/packages.config # src/Orchard.Web/Modules/Upgrade/packages.config # src/Orchard.Web/Themes/packages.config
5 participants
Also includes cherrypicked commit 48685b3 to fix ClickToBuild.cmd.