Added Blockquote element#6773
Merged
Merged
Conversation
Member
|
Tested and reviewed, looks and works fine, both code and functionality. However, I think we should also add a "citation" property to the element, allowing editor control of the rendered <blockquote cite="http://developer.mozilla.org">
<p>This is a quotation taken from the Mozilla Developer Center.</p>
</blockquote>If the citation is not specified, the |
Member
Author
|
Thanks for reviewing! I added the |
Member
|
Why not an HTML section instead of content ? |
Member
Author
|
Section, as in a new Category called HTML containing HTML elements? I would not be opposed to that. |
sfmskywalker
pushed a commit
that referenced
this pull request
Apr 29, 2016
This reverts commit 7d60368.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #6772
This adds a Blockquote element to the toolbox, making it awesome for users to add beautifully styled block quote elements to their page.