Skip to content

Media Library: Add button to select all items, fixes #6518#6610

Merged
BenedekFarkas merged 2 commits into
OrchardCMS:1.10.xfrom
MobesE46:highlight-all-images
May 23, 2019
Merged

Media Library: Add button to select all items, fixes #6518#6610
BenedekFarkas merged 2 commits into
OrchardCMS:1.10.xfrom
MobesE46:highlight-all-images

Conversation

@MobesE46

Copy link
Copy Markdown
Contributor

Fixes #6518 - New button to select all images in media library folder.

Supersedes PR #6519 to target 1.10.x

…dia Library

Changed to "Select All" per Sebastien

Removed stray html attribute
@sebastienros

Copy link
Copy Markdown
Member

GTG once someone has confirmed it works and doesn't break existing features.

@MobesE46

MobesE46 commented Apr 29, 2016

Copy link
Copy Markdown
Contributor Author

Here's the new button:
image

After clicking button:
image

@sebastienros

Copy link
Copy Markdown
Member

What I see from the code is that Select will actually close the window and select items, while Select All will just highlight the items. Is that intentional? It would mean to actually select all items you need to click Select All, then Select. So maybe this button should actually be in the toolbar, so that there is no confusion with the Select action of the picker.

@MobesE46

Copy link
Copy Markdown
Contributor Author

Ok, I moved the button to the Toolbar

image

@OrchardCMS OrchardCMS deleted a comment from dnfclas Dec 11, 2017
@BenedekFarkas

Copy link
Copy Markdown
Member

Confirmed as working, but I'll push some changes/improvements.

@BenedekFarkas BenedekFarkas added this to the Orchard 1.10.4 milestone May 23, 2019
@BenedekFarkas BenedekFarkas changed the title Fixes #6518 - No way to select all images from folder in Media Library Media Library: Add button to select all items, fixes #6518 May 23, 2019
@BenedekFarkas
BenedekFarkas merged commit 40e56c5 into OrchardCMS:1.10.x May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants