Working on this PR i found a problem in RequestTokens.cs in the Evaluate method:

	        context.For("Request", _workContextAccessor.GetContext().HttpContext.Request)
                .Token(
                    FilterTokenParam,
                    (token, request) => {
                        return request.QueryString.Get(token);
                    }
                )
                .Token(
                    FilterTokenParam,
                    (token, request) => request.Form.Get(token)
                )

The function FilterTokenParam don't check the token Name, therefore if i have a token for a QueryString parameter the program try to get the value first in request.QueryString and after in request.Form. If in request.Form there is a parameter with the same name of a parameter searched in the QueryString then the return value is always the one in Request.Form.

The solution is to check the name in .Token and in .Chain:

               .Token( token => token.StartsWith("QueryString:", StringComparison.OrdinalIgnoreCase) ? FilterTokenParam(token) : null,
                   (token, request) => {
                       return request.QueryString.Get(token);
                   }
               )
               .Chain(token => token.StartsWith("QueryString:", StringComparison.OrdinalIgnoreCase) ? FilterChainParam(token) : null,
               "Text", (token, request) => request.QueryString.Get(token))
               .Token(
                   token => token.StartsWith("Form:", StringComparison.OrdinalIgnoreCase) ? FilterTokenParam(token) : null,
                   (token, request) => request.Form.Get(token)
               )
               .Chain(token => token.StartsWith("Form:", StringComparison.OrdinalIgnoreCase) ? FilterChainParam(token) : null
               , "Text", (token, request) => request.Form.Get(token))

Uh oh!

Token For Request Header #8259

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions