Fix crash for preset sync during startup#13797
Merged
Merged
Conversation
SoftFever
added a commit
that referenced
this pull request
May 22, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Startup cloud preset sync can mutate the active preset bundle from a background thread while the GUI render path is reading the same printer preset state. In the observed crash, the 3D canvas was rendering plate icons and called vendor/extruder helper methods while
reload_settings()was applying synced user presets.During this race, the selected printer config could temporarily be missing expected fields such as
printer_modelornozzle_diameter, leading to unsafe reads in the render path.Screenshots/Recordings/Graphs
Tests
How to Download Pull Requests Artifacts for Testing