fix: detached presets not showing up#13793
Merged
Merged
Conversation
|
Hi @peachismomo, you can manage the labels for this PR by Allowed labels are: Examples: |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes cloud preset downloads so “detached” (root) user presets without a base_id are no longer silently ignored, ensuring they appear after syncing/downloading from the cloud.
Changes:
- Allow loading user presets that have no
base_idwhen they don’t inherit from a parent preset. - Adjust custom preset alias generation to avoid producing an empty alias for certain root filament preset names.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2189
to
2202
| // base_id is only required for presets inheriting from a parent. Root presets | ||
| // with an empty "inherits" field intentionally have no base_id. | ||
| std::string cloud_base_id; | ||
| auto base_id_iter = preset_values.find(BBL_JSON_KEY_BASE_ID); | ||
| if (base_id_iter != preset_values.end()) { | ||
| cloud_base_id = base_id_iter->second; | ||
| } else { | ||
| auto inherits_iter = preset_values.find(BBL_JSON_KEY_INHERITS); | ||
| if (inherits_iter != preset_values.end() && !inherits_iter->second.empty()) { | ||
| BOOST_LOG_TRIVIAL(warning) << __FUNCTION__ << boost::format("can not find base_id, not loading for user preset %1%") % canonical_name; | ||
| unlock(); | ||
| return false; | ||
| } | ||
| } |
SoftFever
approved these changes
May 22, 2026
SoftFever
pushed a commit
that referenced
this pull request
May 22, 2026
* fix: detached presets not showing up * slightly better code clarity * remove cloud_prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you save a custom preset as detached from parent, it wont show up when you download from the cloud.
This is because it is being silently ignored when there is no base id.
How to Download Pull Requests Artifacts for Testing