Fix to raft checking logic for slow down layers#13415
Merged
Merged
Conversation
Thanks to valerii-bokhan for picking this up in the previous commit: OrcaSlicer#13224
|
Hi @yogihybo, you can manage the labels for this PR by Allowed labels are: Examples: |
Contributor
Author
|
/bot add-label bug-fix |
Contributor
dbaarda
pushed a commit
to dbaarda/OrcaSlicer
that referenced
this pull request
May 3, 2026
* main: (381 commits) Fix: Fixing the range check in ZAA code (OrcaSlicer#13452) Fix role-based fan speeds being lost on layer change (OrcaSlicer#13390) PR OrcaSlicer#12525 follow-up (OrcaSlicer#13440) Correct center grid multiline (OrcaSlicer#13422) Fix to raft checking logic for slow down layers (OrcaSlicer#13415) Fix: Expose support_chamber_temp_control flag outside developer mode (OrcaSlicer#12924) (OrcaSlicer#13393) Tweak UI 1. Move ZAA options to comExpert 2. Expose zaa_dont_alternate_fill_direction to the UI 3. Remove ironing_expansion from UI as it's not implemented fixed an issue that zaa_enabled is redefined in both object and region. move all zaa config to region to keep it consistent Feature/per vendor update (OrcaSlicer#13394) Introducing Orca Cloud: https://cloud.orcaslicer.com (OrcaSlicer#13414) Hook up deps-windows.cmake too Add processor mapping for ARM64 -> DEPS_ARCH=arm64 With this change, builds on ARM64 hosts will successfully kick off! Unfortunately there are still missing/outdated dependencies, so the build doesn't yet succeed. This makes it much easier to check what we're failing on though. Fix outer wall for bridges (OrcaSlicer#13411) Fix and Improve 3MF impOrt (OrcaSlicer#13403) Fix a regression issue orca couldn't login into BBL cloud (OrcaSlicer#13407) revert pure format changes Fixed a bug where `zaa_dont_alternate_fill_direction` still had an effect even when ZAA is disabled. Fixed a bug where the scarf seam wouldn't work properly when ZAA was disabled. fix missing settings after merging Update profiles identation (OrcaSlicer#13375) ...
dbaarda
pushed a commit
to dbaarda/OrcaSlicer
that referenced
this pull request
May 3, 2026
* main: (417 commits) Fix: Fixing the range check in ZAA code (OrcaSlicer#13452) Fix role-based fan speeds being lost on layer change (OrcaSlicer#13390) PR OrcaSlicer#12525 follow-up (OrcaSlicer#13440) Correct center grid multiline (OrcaSlicer#13422) Fix to raft checking logic for slow down layers (OrcaSlicer#13415) Fix: Expose support_chamber_temp_control flag outside developer mode (OrcaSlicer#12924) (OrcaSlicer#13393) Tweak UI 1. Move ZAA options to comExpert 2. Expose zaa_dont_alternate_fill_direction to the UI 3. Remove ironing_expansion from UI as it's not implemented fixed an issue that zaa_enabled is redefined in both object and region. move all zaa config to region to keep it consistent Feature/per vendor update (OrcaSlicer#13394) Introducing Orca Cloud: https://cloud.orcaslicer.com (OrcaSlicer#13414) Hook up deps-windows.cmake too Add processor mapping for ARM64 -> DEPS_ARCH=arm64 With this change, builds on ARM64 hosts will successfully kick off! Unfortunately there are still missing/outdated dependencies, so the build doesn't yet succeed. This makes it much easier to check what we're failing on though. Fix outer wall for bridges (OrcaSlicer#13411) Fix and Improve 3MF impOrt (OrcaSlicer#13403) Fix a regression issue orca couldn't login into BBL cloud (OrcaSlicer#13407) revert pure format changes Fixed a bug where `zaa_dont_alternate_fill_direction` still had an effect even when ZAA is disabled. Fixed a bug where the scarf seam wouldn't work properly when ZAA was disabled. fix missing settings after merging Update profiles identation (OrcaSlicer#13375) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thanks to valerii-bokhan for picking this up issue when reviewing the previous pull requested (already merged): #13224
expression use this to detect when no raft was this (worked but not right):
} else if (m_config.slow_down_layers > 1 && !m_config.raft_layers > 0) {
corrected to use this logic:
} else if (m_config.slow_down_layers > 1 && m_config.raft_layers == 0) {
Screenshots/Recordings/Graphs
No change to the previous slowdown functions including the slowing down of layers over raft
Tests
Compiled locally and check that logic works