Skip to content

Fix outer wall for bridges#13411

Merged
RF47 merged 1 commit into
OrcaSlicer:mainfrom
kisslorand:Fix-outer-wall-for-bridges
Apr 30, 2026
Merged

Fix outer wall for bridges#13411
RF47 merged 1 commit into
OrcaSlicer:mainfrom
kisslorand:Fix-outer-wall-for-bridges

Conversation

@kisslorand

@kisslorand kisslorand commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix a regression where enabling "Bridge counterbore holes" by "Partially bridged" affected ordinary bridges and caused them to lose their overhang-wall generation.

The issue

When "Partially bridged" was enabled, regular bridges that had nothing to do with counterbore holes could lose their overhang walls / outer wall behavior. In preview this showed up as bridge regions being sliced differently than expected, with missing overhang-wall perimeters on normal bridge spans.

Cause

The "Partially bridged" path was rewriting generic unsupported bridge islands, not just counterbore-like bridge surfaces.
That geometry rewrite happened before later perimeter classification, so ordinary bridge islands could lose the unsupported perimeter regions that are normally turned into overhang walls.

Fix

Restrict Partially bridged processing to hole-bearing bridge islands only.
If the current bridge surface has no holes, skip the partial-bridge rewrite entirely.

Result

Ordinary bridges keep their expected overhang walls even when Bridge counterbore holes is set to "Partially bridged".
Actual counterbore-like bridge islands continue to use partial-bridge processing.
The setting no longer changes unrelated regular bridges.

Fixes #13344

Screenshots

  • Before:
image
  • After:
image

@kisslorand
Fix outer wall for bridges
44dde96 
- prevent Partially bridged counterbore processing from rewriting ordinary bridge islands, restoring overhang walls on normal bridges
@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown

Hi @kisslorand, you can manage the labels for this PR by /bot add-label and /bot remove-label

Allowed labels are:
bug-fix, enhancement, Localization, profile, QoL, UI/UX and dependencies.

Examples:

/bot add-label bug-fix

/bot add-label bug-fix, UI/UX

/bot remove-label bug-fix, UI/UX

RF47
RF47 approved these changes Apr 30, 2026
View reviewed changes

@RF47 RF47 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RF47 RF47 merged commit e54e7a6 into OrcaSlicer:main Apr 30, 2026
19 checks passed
@valerii-bokhan

valerii-bokhan commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

I have a question. :)

I am not against this fix, but... I abused this bug because it was my workaround for another issue.

If we leave it as is - yes, walls will be walls and not bridges, but at the same time, walls will be printed first (Print infill first is false by default), meaning that they will not have anything to stick to, and 90-degree overhang speed will be used + an overhang flow ratio if set.

In this case, walls will 100% "ooze".

The solution would be to print the bridge lines first so the walls have at least something to stick to. But it will work only with the Inner/Outer wall order, though.

image

To address it, I would rather ignore Print infill first for external bridges and print them first in 100% cases, then walls, or I'd add a setting that works the same as Print infill first, but for external bridges specifically (to let users decide if they want to print ext bridges first then walls or not).

P.S. I can't just turn on the Print infill first setting because it ruins the quality of my print walls.

@valerii-bokhan

valerii-bokhan commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

@RF47 @kisslorand, what do you think about my previous comment? Does it make sense? If yes, I would look into it as a separate change.

@RF47

RF47 commented May 1, 2026

Copy link
Copy Markdown
Collaborator

Hmm, there was no way I’d have realised that a bug could be used like that, ha ha ha. Let’s hear some more opinions; I think it’s a harmless bug anyway.

@igiannakas

igiannakas commented May 1, 2026

Copy link
Copy Markdown
Collaborator

I’ve heard about this but also being used to print outer walls with bridge settings.

however the “right way” to do this would be:

  1. Fix this bug
  2. Create an option to apply bridging parameters to bridge walls, segment the outer walls and include them as part of the bridge

I think SS has an option to do that so code could be used for inspiration.

@Felix14-v2

Felix14-v2 commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Yeah, this bug was (ab)used in some cases like these:
#8296 (comment)
#10036
#8557 (comment)
#1340
And a couple of extra screenshots with mid-air prints fixed by partial bridge:
IMG_20260501_121636_337
IMG_20260501_121922_460

igiannakas added a commit to igiannakas/OrcaSlicer that referenced this pull request May 1, 2026
@igiannakas
Squashed commit of the following:
f63796c 
commit 3d44fa5
Author: yw4z <[email protected]>
Date:   Fri May 1 15:14:53 2026 +0300

    Update GLGizmoMmuSegmentation.cpp

commit ea44a2a
Author: yw4z <[email protected]>
Date:   Fri May 1 13:43:01 2026 +0300

    Update GLGizmoMmuSegmentation.cpp

commit 2e8e282
Author: yw4z <[email protected]>
Date:   Fri May 1 02:22:37 2026 +0300

    fix build error

commit f661355
Author: yw4z <[email protected]>
Date:   Fri May 1 01:58:34 2026 +0300

    init

commit e54e7a6
Author: Kiss Lorand <[email protected]>
Date:   Fri May 1 00:35:42 2026 +0300

    Fix outer wall for bridges (OrcaSlicer#13411)
dbaarda pushed a commit to dbaarda/OrcaSlicer that referenced this pull request May 3, 2026
Merge branch 'main' into upd-eigen-5.0.0
25437a5 
* main: (381 commits)
  Fix: Fixing the range check in ZAA code (OrcaSlicer#13452)
  Fix role-based fan speeds being lost on layer change (OrcaSlicer#13390)
  PR OrcaSlicer#12525 follow-up (OrcaSlicer#13440)
  Correct center grid multiline (OrcaSlicer#13422)
  Fix to raft checking logic for slow down layers (OrcaSlicer#13415)
  Fix: Expose support_chamber_temp_control flag outside developer mode (OrcaSlicer#12924) (OrcaSlicer#13393)
  Tweak UI 1. Move ZAA options to comExpert 2. Expose zaa_dont_alternate_fill_direction to the UI 3. Remove ironing_expansion from UI as it's not implemented
  fixed an issue that zaa_enabled is redefined in both object and region. move all zaa config to region to keep it consistent
  Feature/per vendor update (OrcaSlicer#13394)
  Introducing Orca Cloud: https://cloud.orcaslicer.com (OrcaSlicer#13414)
  Hook up deps-windows.cmake too
  Add processor mapping for ARM64 -> DEPS_ARCH=arm64 With this change, builds on ARM64 hosts will successfully kick off! Unfortunately there are still missing/outdated dependencies, so the build doesn't yet succeed. This makes it much easier to check what we're failing on though.
  Fix outer wall for bridges (OrcaSlicer#13411)
  Fix and Improve 3MF impOrt (OrcaSlicer#13403)
  Fix a regression issue orca couldn't login into BBL cloud (OrcaSlicer#13407)
  revert pure format changes
  Fixed a bug where `zaa_dont_alternate_fill_direction` still had an effect even when ZAA is disabled.
  Fixed a bug where the scarf seam wouldn't work properly when ZAA was disabled.
  fix missing settings after merging
  Update profiles identation (OrcaSlicer#13375)
  ...
dbaarda pushed a commit to dbaarda/OrcaSlicer that referenced this pull request May 3, 2026
Merge branch 'main' into imp-thickbridges
39580f5 
* main: (417 commits)
  Fix: Fixing the range check in ZAA code (OrcaSlicer#13452)
  Fix role-based fan speeds being lost on layer change (OrcaSlicer#13390)
  PR OrcaSlicer#12525 follow-up (OrcaSlicer#13440)
  Correct center grid multiline (OrcaSlicer#13422)
  Fix to raft checking logic for slow down layers (OrcaSlicer#13415)
  Fix: Expose support_chamber_temp_control flag outside developer mode (OrcaSlicer#12924) (OrcaSlicer#13393)
  Tweak UI 1. Move ZAA options to comExpert 2. Expose zaa_dont_alternate_fill_direction to the UI 3. Remove ironing_expansion from UI as it's not implemented
  fixed an issue that zaa_enabled is redefined in both object and region. move all zaa config to region to keep it consistent
  Feature/per vendor update (OrcaSlicer#13394)
  Introducing Orca Cloud: https://cloud.orcaslicer.com (OrcaSlicer#13414)
  Hook up deps-windows.cmake too
  Add processor mapping for ARM64 -> DEPS_ARCH=arm64 With this change, builds on ARM64 hosts will successfully kick off! Unfortunately there are still missing/outdated dependencies, so the build doesn't yet succeed. This makes it much easier to check what we're failing on though.
  Fix outer wall for bridges (OrcaSlicer#13411)
  Fix and Improve 3MF impOrt (OrcaSlicer#13403)
  Fix a regression issue orca couldn't login into BBL cloud (OrcaSlicer#13407)
  revert pure format changes
  Fixed a bug where `zaa_dont_alternate_fill_direction` still had an effect even when ZAA is disabled.
  Fixed a bug where the scarf seam wouldn't work properly when ZAA was disabled.
  fix missing settings after merging
  Update profiles identation (OrcaSlicer#13375)
  ...
@kisslorand kisslorand deleted the Fix-outer-wall-for-bridges branch May 14, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RF47 RF47 RF47 approved these changes

Assignees

No one assigned

Labels

bug-fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bridge counterbore holes affects area without holes

5 participants

@kisslorand @valerii-bokhan @RF47 @igiannakas @Felix14-v2