Note: I don’t know what the root cause is of it accepting an invalid filament; I need help with that

Cube.3mf contains custom printer G-code with literal T10 commands in machine_end_gcode

Orca parses that T10, correctly recognizes it as invalid because 10 >= m_result.filaments_count, but then still calls process_filament_change(10).

if (eid >= m_result.filaments_count)
   BOOST_LOG_TRIVIAL(error) << "Invalid T command (" << command << ").";
process_filament_change(eid);

So the access violation is not caused by the 3MF being broken. It is caused by:

• Project-specific custom G-code using T10 as a printer command.
• Newer Orca misinterpreting that as a slicer filament change.
• A missing early return after detecting the tool id is out of range.

Same behavior can be observed with M1020 command also:

if (eid >= m_result.filaments_count)
    BOOST_LOG_TRIVIAL(error) << "Invalid M1020 command (" << line.raw() << ").";
process_filament_change(eid);

I would fix it like this:

void GCodeProcessor::process_M1020(const GCodeReader::GCodeLine &line)
{
    ...
    else {
        if (eid >= m_result.filaments_count) {
            BOOST_LOG_TRIVIAL(error) << "Invalid M1020 command (" << line.raw() << ").";
            return;
        }
        process_filament_change(eid);
    }
}

void GCodeProcessor::process_T(const std::string_view command)
{
    ...
    else {
        if (eid >= m_result.filaments_count) {
            BOOST_LOG_TRIVIAL(error) << "Invalid T command (" << command << ").";
            return;
        }
        process_filament_change(static_cast<int>(eid));
    }
}

or

void GCodeProcessor::process_M1020(const GCodeReader::GCodeLine &line)
{
    ...
    else {
        if (eid >= m_result.filaments_count)
            BOOST_LOG_TRIVIAL(error) << "Invalid T command (" << command << ").";
        else
            process_filament_change(static_cast<int>(eid));
    }
}

void GCodeProcessor::process_T(const std::string_view command)
{
    ...
    else {
        if (eid >= m_result.filaments_count)
            BOOST_LOG_TRIVIAL(error) << "Invalid T command (" << command << ").";
        else
            process_filament_change(static_cast<int>(eid));
    }
}

I'll try it as soon as I can, Thanks!

I'll try it as soon as I can, Thanks!

@kisslorand it works, you are right.

with literal T10 commands in machine_end_gcode

Shouldn't we raise a proper error message saying something like "invalid T10 command" instead of silently ignoring it?

with literal T10 commands in machine_end_gcode

Shouldn't we raise a proper error message saying something like "invalid T10 command" instead of silently ignoring it?

But in that case, an error message would pop up for every slice in that machine profile – wouldn't that be rather annoying?

something like that?

But in that case, an error message would pop up for every slice in that machine profile – wouldn't that be rather annoying?

Then maybe fix that profile? Unless a "T10" is required for that printer to function properly, otherwise it just doesn't make sence to me.

Then maybe fix that profile? Unless a "T10" is required for that printer to function properly, otherwise it just doesn't make sence to me.

#12704 (comment)

I see. That's kinda annoying but I guess we have to live with that then.

something like that?

Adding a warning notification is dangerous: one may think that the profile is broken and try to "fix" it themselves by removing unknown Gcode commands. Which may cause damage to the printer during the execution process.

If we need a warning anyways, I'd prefer it to be displayed under the gcode section when you edit printer gcode.

something like that?

Adding a warning notification is dangerous: one may think that the profile is broken and try to "fix" it themselves by removing unknown Gcode commands. Which may cause damage to the printer during the execution process.

If we need a warning anyways, I'd prefer it to be displayed under the gcode section when you edit printer gcode.

In the current implementation, it saves it in the log.

Yeah if it's required for that printer to work, then we should not warn the user to avoid any confusion.