Don't steal focus from text inputs on mouse#12834
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression where moving the mouse into the 3D viewport could steal focus from sidebar text inputs, causing selected text to be deselected (Issue #12823).
Changes:
- Adds a guard in
GLCanvas3D::on_mouse()to avoid focusing the 3D canvas when a text-input-like control currently has focus. - Introduces focus-type checks using
dynamic_castagainst common wxWidgets input controls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yw4z
reviewed
Mar 18, 2026
In GLCanvas3D::on_mouse, avoid calling SetFocus when the currently focused window is a text input control (wxTextCtrl, wxComboBox or wxSpinCtrl). This prevents deselection bugs when the mouse leaves the window while a text control is focused. Also commented out explicit wx text-control includes near the top of the file. Only TextCtrl needed cleaning Removed unused wxWidgets header includes. Update GLCanvas3D.cpp Co-Authored-By: yw4z <[email protected]>
Collaborator
|
LGTM thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix a bug introduced in 382cf57
When moving the mouse over the 3D viewport, the focus was lost on the selected text.
Fix #12823