Feature/optimize warnings#12821
Merged
Merged
Conversation
Flushing volumes only apply to SEMM and BBL printers. Multi-tool printers don't perform filament purging between tool changes, so the zero-volume warning was being incorrectly triggered.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces confusion around wipe/prime-tower related warnings by gating flushing-volume validation to SEMM/BBL scenarios and by adding/adjusting validation/warnings for the precise_z_height + enable_prime_tower conflict.
Changes:
- Skip flushing-volume matrix validation when SEMM UI is not applicable (non-SEMM, non-BBL printers).
- Update GUI warning strings and conflict handling for
precise_z_heightvsenable_prime_tower. - Add a print validation warning when prime tower is enabled alongside precise Z height on any object.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/slic3r/GUI/Tab.cpp | Updates UI warning text/behavior when toggling enable_prime_tower and precise_z_height. |
| src/slic3r/GUI/GLCanvas3D.cpp | Skips flushing-volume matrix “zero” warning validation for non-SEMM/non-BBL contexts. |
| src/libslic3r/Print.cpp | Adds a Print::validate() warning for the prime tower + precise Z height conflict. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tweak some wipe tower related warnings to reduce confusion
Screenshots/Recordings/Graphs
Tests