Update condition to check for "Extruder" nozzle count for Customize Filament Sequence#12735
Closed
o1hitman1o wants to merge 1 commit into
Closed
Update condition to check for "Extruder" nozzle count for Customize Filament Sequence#12735o1hitman1o wants to merge 1 commit into
o1hitman1o wants to merge 1 commit into
Conversation
Collaborator
Author
|
@Noisyfox Will you take a look at this to make sure this is correct since you had added the change a few months ago. |
…ilament Sequence Prior logic was checking for a BBL printer or if the amount of filament/colors was = 1 but it should have been checking if the "extruder" nozzle count is = 1. This was putting single extruder printers with multi-color prints into the non-bbl multi-extruder printers check and the color sequence was ignored. This correctly checks for extruder count and not the filament color count.
Collaborator
|
LGTM |
Noisyfox
approved these changes
Mar 14, 2026
Collaborator
|
Though another problem is that I don't remember why non-bbl multi-extruder printer does not follow the plate filament order. Seems to be a separate bug. |
Collaborator
|
What if we do this instead: 
Update: this causes issue for non-bbl multi-tool printer when not using custom filament order. |
3 tasks
Collaborator
|
I proposed a different fix #12767 which should take care of both SEMM and multi-tool non-bbl printers. Could you give it a try? |
Author
|
Tested on my end and works as expected for SEMM and multi-tool non-bbl printer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prior logic was checking for a BBL printer or if the amount of filament/colors was = 1 but it should have been checking if the "extruder" nozzle count is = 1. This was putting single extruder printers with multi-color prints into the non-bbl multi-extruder printers check and the color sequence was ignored. This correctly checks for extruder count and not the filament color count.
fixes #12449
Tests
Built and tested on Windows 11