Improves usability on Linux. No more double title bar by SoftFever · Pull Request #12600 · OrcaSlicer/OrcaSlicer

SoftFever · 2026-03-04T11:10:06Z

Description

This PR improves usability on Linux. No more double title bar on Linux now.
We now have the same sleek look on Linux as on Windows and macOS.

Screenshots/Recordings/Graphs

Before:

Now:

Tests

Copilot

Pull request overview

This PR fixes the double title bar issue on Linux by suppressing the window manager's native title bar (via m_gdkDecor = 0) and implementing a custom WM-integrated resize border handler (GtkResizeBorderHandler) and drag/maximize interactions using native GTK APIs. It also removes a stray task.md developer-notes file.

Changes:

Adds a GtkResizeBorderHandler wxEventFilter class to provide resize cursor and gtk_window_begin_resize_drag()-based window resizing for the borderless GTK window.
Implements GTK-specific window drag (gtk_window_begin_move_drag) and maximize/unmaximize (gtk_window_maximize/gtk_window_unmaximize) in the topbar.
Removes the task.md developer scratch file from the repo.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`task.md`	Removes an accidentally committed developer scratch/notes file unrelated to the PR
`src/slic3r/GUI/MainFrame.hpp`	Declares the nested `GtkResizeBorderHandler` class and its pointer member for GTK builds
`src/slic3r/GUI/MainFrame.cpp`	Implements `GtkResizeBorderHandler`, sets `m_gdkDecor = 0` to remove WM title bar, installs/cleans up the handler
`src/slic3r/GUI/BBLTopbar.cpp`	Adds GTK-native window move drag and maximize/restore in the topbar event handlers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-04T11:16:13Z

+        GdkCursorType cursor_type;
+        switch (edge) {
+        case GDK_WINDOW_EDGE_NORTH:       cursor_type = GDK_TOP_SIDE;           break;
+        case GDK_WINDOW_EDGE_SOUTH:       cursor_type = GDK_BOTTOM_SIDE;        break;
+        case GDK_WINDOW_EDGE_WEST:        cursor_type = GDK_LEFT_SIDE;          break;
+        case GDK_WINDOW_EDGE_EAST:        cursor_type = GDK_RIGHT_SIDE;         break;
+        case GDK_WINDOW_EDGE_NORTH_WEST:  cursor_type = GDK_TOP_LEFT_CORNER;    break;
+        case GDK_WINDOW_EDGE_NORTH_EAST:  cursor_type = GDK_TOP_RIGHT_CORNER;   break;
+        case GDK_WINDOW_EDGE_SOUTH_WEST:  cursor_type = GDK_BOTTOM_LEFT_CORNER; break;
+        case GDK_WINDOW_EDGE_SOUTH_EAST:  cursor_type = GDK_BOTTOM_RIGHT_CORNER;break;
+        default: return;
+        }
+
+        GdkDisplay* display = gtk_widget_get_display(m_frame->m_widget);
+        GdkCursor*  cursor  = gdk_cursor_new_for_display(display, cursor_type);
+        gdk_window_set_cursor(gtk_widget_get_window(m_frame->m_widget), cursor);
+        g_object_unref(cursor);
+        m_cursor_set = true;
+    }
+
+    MainFrame* m_frame;
+    bool       m_cursor_set{false};


The set_cursor_for_edge() method is called unconditionally on every wxEVT_MOTION event when the cursor is near a border edge. It creates and destroys a new GdkCursor object each time via gdk_cursor_new_for_display() + g_object_unref(). Since mouse motion events can fire many times per second, this causes frequent GDK cursor object allocation and deallocation.

Additionally, gdk_cursor_new_for_display() with a GdkCursorType argument has been deprecated since GTK 3.16. The recommended replacement is gdk_cursor_new_from_name().

To fix the performance issue, track the last edge that was set (e.g., add a GdkWindowEdge m_last_edge member and a sentinel value like -1 or an std::optional<GdkWindowEdge>) and skip recreating the cursor when the edge hasn't changed. To fix the deprecation, use gdk_cursor_new_from_name() with CSS cursor names (e.g., "n-resize", "s-resize", "w-resize", "e-resize", "nw-resize", "ne-resize", "sw-resize", "se-resize").

Suggested change

GdkCursorType cursor_type;

switch (edge) {

case GDK_WINDOW_EDGE_NORTH: cursor_type = GDK_TOP_SIDE; break;

case GDK_WINDOW_EDGE_SOUTH: cursor_type = GDK_BOTTOM_SIDE; break;

case GDK_WINDOW_EDGE_WEST: cursor_type = GDK_LEFT_SIDE; break;

case GDK_WINDOW_EDGE_EAST: cursor_type = GDK_RIGHT_SIDE; break;

case GDK_WINDOW_EDGE_NORTH_WEST: cursor_type = GDK_TOP_LEFT_CORNER; break;

case GDK_WINDOW_EDGE_NORTH_EAST: cursor_type = GDK_TOP_RIGHT_CORNER; break;

case GDK_WINDOW_EDGE_SOUTH_WEST: cursor_type = GDK_BOTTOM_LEFT_CORNER; break;

case GDK_WINDOW_EDGE_SOUTH_EAST: cursor_type = GDK_BOTTOM_RIGHT_CORNER;break;

default: return;

}

GdkDisplay* display = gtk_widget_get_display(m_frame->m_widget);

GdkCursor* cursor = gdk_cursor_new_for_display(display, cursor_type);

gdk_window_set_cursor(gtk_widget_get_window(m_frame->m_widget), cursor);

g_object_unref(cursor);

m_cursor_set = true;

}

MainFrame* m_frame;

bool m_cursor_set{false};

// Avoid recreating the cursor if the edge (and thus cursor shape) has not changed.

if (m_last_edge_valid && m_cursor_set && edge == m_last_edge)

return;

const char *cursor_name = nullptr;

switch (edge) {

case GDK_WINDOW_EDGE_NORTH: cursor_name = "n-resize"; break;

case GDK_WINDOW_EDGE_SOUTH: cursor_name = "s-resize"; break;

case GDK_WINDOW_EDGE_WEST: cursor_name = "w-resize"; break;

case GDK_WINDOW_EDGE_EAST: cursor_name = "e-resize"; break;

case GDK_WINDOW_EDGE_NORTH_WEST: cursor_name = "nw-resize"; break;

case GDK_WINDOW_EDGE_NORTH_EAST: cursor_name = "ne-resize"; break;

case GDK_WINDOW_EDGE_SOUTH_WEST: cursor_name = "sw-resize"; break;

case GDK_WINDOW_EDGE_SOUTH_EAST: cursor_name = "se-resize"; break;

default:

return;

}

GdkDisplay* display = gtk_widget_get_display(m_frame->m_widget);

GdkCursor* cursor = gdk_cursor_new_from_name(display, cursor_name);

if (!cursor)

return;

gdk_window_set_cursor(gtk_widget_get_window(m_frame->m_widget), cursor);

g_object_unref(cursor);

m_cursor_set = true;

m_last_edge = edge;

m_last_edge_valid = true;

}

MainFrame* m_frame;

bool m_cursor_set{false};

GdkWindowEdge m_last_edge;

bool m_last_edge_valid{false};

github-actions · 2026-03-04T12:03:44Z

Test Results

0 tests 0 ✅ 0s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit aa631b0.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-04T14:33:01Z

+        if (t == wxEVT_LEFT_DOWN) {
+            gtk_window_begin_resize_drag(
+                GTK_WINDOW(m_frame->m_widget),
+                edge,
+                1,                            // left mouse button
+                mouse.x, mouse.y,
+                gtk_get_current_event_time());
+            return Event_Processed;


The GtkResizeBorderHandler::FilterEvent intercepts all wxEVT_LEFT_DOWN events application-wide without checking whether the event's target window is the main frame or one of its direct children. If any widget (e.g., a popup menu, dropdown, or child panel) is positioned within the 8-pixel border zone at the frame's edge, a left-click on it will be intercepted and transformed into a resize drag operation instead, eating the click entirely (since Event_Processed is returned).

To fix this, the filter should check that the event's target window (event.GetEventObject()) is either the main frame itself or that no other top-level window is active/focused (e.g., using wxWindow::FindFocus() or checking wxGetTopLevelParent of the event object). Alternatively, set the cursor only on the root GDK window but only begin the drag when the event source is the main GDK window.

* Fix double title bar on Linux by removing WM decorations for GTK * wip * fix * finish * address review comment

…variables (#12602) * Linux: prefer discrete GPU on dual-GPU systems via PRIME environment variables Set DRI_PRIME=1 for AMD/nouveau PRIME setups and __NV_PRIME_RENDER_OFFLOAD/__GLX_VENDOR_LIBRARY_NAME for NVIDIA proprietary driver, only when the NVIDIA kernel module is detected. Uses replace=false to respect user overrides. * Improves usability on Linux. No more double title bar (#12600) * Fix double title bar on Linux by removing WM decorations for GTK * wip * fix * finish * address review comment

timnolte · 2026-03-06T03:46:28Z

This work is not good for Linux users. The result of this is that now the file name and the file change state is no longer in the Title Bar. Removing the native Title Bar breaks functionality. This needs to be reverted or changed so the built-in Title Bar contains the file name.

* Fix double title bar on Linux by removing WM decorations for GTK * wip * fix * finish * address review comment

…variables (OrcaSlicer#12602) * Linux: prefer discrete GPU on dual-GPU systems via PRIME environment variables Set DRI_PRIME=1 for AMD/nouveau PRIME setups and __NV_PRIME_RENDER_OFFLOAD/__GLX_VENDOR_LIBRARY_NAME for NVIDIA proprietary driver, only when the NVIDIA kernel module is detected. Uses replace=false to respect user overrides. * Improves usability on Linux. No more double title bar (OrcaSlicer#12600) * Fix double title bar on Linux by removing WM decorations for GTK * wip * fix * finish * address review comment

* Fix double title bar on Linux by removing WM decorations for GTK * wip * fix * finish * address review comment

…variables (OrcaSlicer#12602) * Linux: prefer discrete GPU on dual-GPU systems via PRIME environment variables Set DRI_PRIME=1 for AMD/nouveau PRIME setups and __NV_PRIME_RENDER_OFFLOAD/__GLX_VENDOR_LIBRARY_NAME for NVIDIA proprietary driver, only when the NVIDIA kernel module is detected. Uses replace=false to respect user overrides. * Improves usability on Linux. No more double title bar (OrcaSlicer#12600) * Fix double title bar on Linux by removing WM decorations for GTK * wip * fix * finish * address review comment

SoftFever added 5 commits March 4, 2026 00:59

Fix double title bar on Linux by removing WM decorations for GTK

8d0695c

wip

9d5f677

fix

d9bae98

Merge branch 'main' into feature/fix-double-title-bar-in-Linux

efc1c23

finish

aa631b0

Copilot AI review requested due to automatic review settings March 4, 2026 11:10

Copilot started reviewing on behalf of SoftFever March 4, 2026 11:10 View session

SoftFever added the 2.3.2 label Mar 4, 2026

SoftFever self-assigned this Mar 4, 2026

SoftFever added the Community testers wanted Looking for community testers and feedback label Mar 4, 2026

SoftFever added this to the 2.3.2 milestone Mar 4, 2026

SoftFever changed the title ~~Feature/fix double title bar in linux~~ Improves usability on Linux. No more double title bar Mar 4, 2026

Copilot AI reviewed Mar 4, 2026

View reviewed changes

address review comment

920b948

SoftFever requested a review from Copilot March 4, 2026 14:20

Copilot started reviewing on behalf of SoftFever March 4, 2026 14:21 View session

SoftFever merged commit d50b4cb into main Mar 4, 2026
16 checks passed

SoftFever deleted the feature/fix-double-title-bar-in-Linux branch March 4, 2026 14:29

Copilot AI reviewed Mar 4, 2026

View reviewed changes

SoftFever added a commit that referenced this pull request Mar 4, 2026

Improves usability on Linux. No more double title bar (#12600)

78a38b2

* Fix double title bar on Linux by removing WM decorations for GTK * wip * fix * finish * address review comment

timnolte mentioned this pull request Mar 6, 2026

Removal of System Title Bar on Linux breaks file name display and change state in Title Bar(no longer presented) #12636

Closed

Xipit pushed a commit to Xipit/OrcaSlicer that referenced this pull request Mar 16, 2026

Improves usability on Linux. No more double title bar (OrcaSlicer#12600)

51b4196

* Fix double title bar on Linux by removing WM decorations for GTK * wip * fix * finish * address review comment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improves usability on Linux. No more double title bar#12600

Improves usability on Linux. No more double title bar#12600
SoftFever merged 6 commits into
mainfrom
feature/fix-double-title-bar-in-Linux

SoftFever commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 4, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

timnolte commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

SoftFever commented Mar 4, 2026

Description

Screenshots/Recordings/Graphs

Tests

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 4, 2026

Test Results

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

timnolte commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants