fix build errors on Linux with Clang 20 and GTK warnings#12507
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the top-level CMake configuration to avoid a Clang 20 build failure by only adding -Wno-error=enum-constexpr-conversion when the active compiler actually supports that flag.
Changes:
- Adds
CheckCXXCompilerFlagusage to probe support for-Wno-error=enum-constexpr-conversion. - Applies
-Wno-error=enum-constexpr-conversiononly when the probe succeeds (for Clang/AppleClang > 15).
Comments suppressed due to low confidence (1)
CMakeLists.txt:440
- For consistency with other uses of
check_cxx_compiler_flagin this repo (and to avoid CMake list parsing edge-cases), pass the flag as a quoted string (e.g., "-Wno-error=...") rather than an unquoted argument.
check_cxx_compiler_flag(-Wno-error=enum-constexpr-conversion HAS_WNO_ERROR_ENUM_CONSTEXPR_CONV)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…egistrations in WebView
SoftFever
changed the title
dbaarda
pushed a commit
to dbaarda/OrcaSlicer
that referenced
this pull request
Mar 3, 2026
* upstream/main: (34 commits) Fix Bambu LAN printing with legacy network plugin (OrcaSlicer#12582) WIP: Parallelize macOS CI builds by splitting arm64 and x86_64 into separate jobs (OrcaSlicer#12562) VOLUMIC profils updates (OrcaSlicer#12565) Fix wiki redirection (OrcaSlicer#12569) Fix Celsius symbol not showing on G-code viewer (OrcaSlicer#12567) Revert "Revert "Set NSWindow color space to sRGB on macOS"" (OrcaSlicer#12546) Improve and complement the pt-BR translation (OrcaSlicer#12550) fix build errors on Linux with Clang 20 and GTK warnings (OrcaSlicer#12507) Fix "Glidlines" "gridlines locale (OrcaSlicer#12529) fix: typo "Glidlines" → "Gridlines" in View menu tooltip (OrcaSlicer#12527) Fix missing infill layers (fill_surface_by_multilines & fill_surface_trapezoidal bug fix) (OrcaSlicer#12516) fix missing translations for Canvas Toolbar Menu update profile version update locale Add option for hiding / showing gridlines (OrcaSlicer#10545) update locale and Simplified/Tranditional Chinese translation Enhancement: Enabling base patterns (infill) for Organic supports (OrcaSlicer#12141) I18n: Preview translations minor fix (Ukrainian) (OrcaSlicer#12504) update locale Fix: Init Serialized options (OrcaSlicer#12489) ...
Xipit
pushed a commit
to Xipit/OrcaSlicer
that referenced
this pull request
Mar 16, 2026
…12507) * guard -Wno-error=enum-constexpr-conversion behind compiler flag check * Fix: Suppress GTK critical warnings and prevent multiple URI scheme registrations in WebView
davidjdixon
pushed a commit
to davidjdixon/OrcaSlicer
that referenced
this pull request
Mar 21, 2026
…12507) * guard -Wno-error=enum-constexpr-conversion behind compiler flag check * Fix: Suppress GTK critical warnings and prevent multiple URI scheme registrations in WebView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Recordings/Graphs
Tests