Fix 3MF import crash for silent-mode machine limits with legacy vector sizes#12289
Merged
Merged
Conversation
…r sizes
Normalize printer_options_with_variant_2 (stride=2) machine limit vectors during preset merge to handle legacy 3MF/projects that store only a single
(normal,silent) pair despite multiple printer variants, preventing set_with_restore() size-mismatch crashes.
Collaborator
|
Thanks @Argolein. |
SoftFever
pushed a commit
that referenced
this pull request
Feb 15, 2026
…r sizes (#12289) Normalize printer_options_with_variant_2 (stride=2) machine limit vectors during preset merge to handle legacy 3MF/projects that store only a single (normal,silent) pair despite multiple printer variants, preventing set_with_restore() size-mismatch crashes. Crash error message during 3MF import as project: <img width="833" height="274" alt="image" src="https://github.com/user-attachments/assets/f92148a9-98c6-47b7-a0ab-d5ac8b1f2be4" /> 3MF attached that causes the bug. [cube.3mf.zip](https://github.com/user-attachments/files/25318309/cube.3mf.zip)
Contributor
Author
|
Snapmaker Orca. But idk really from what version they forked it from. |
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 17, 2026
…r sizes (OrcaSlicer#12289) Normalize printer_options_with_variant_2 (stride=2) machine limit vectors during preset merge to handle legacy 3MF/projects that store only a single (normal,silent) pair despite multiple printer variants, preventing set_with_restore() size-mismatch crashes. Crash error message during 3MF import as project: <img width="833" height="274" alt="image" src="https://github.com/user-attachments/assets/f92148a9-98c6-47b7-a0ab-d5ac8b1f2be4" /> 3MF attached that causes the bug. [cube.3mf.zip](https://github.com/user-attachments/files/25318309/cube.3mf.zip)
tome9111991
pushed a commit
to tome9111991/OrcaSlicer
that referenced
this pull request
Feb 24, 2026
…r sizes (OrcaSlicer#12289) Normalize printer_options_with_variant_2 (stride=2) machine limit vectors during preset merge to handle legacy 3MF/projects that store only a single (normal,silent) pair despite multiple printer variants, preventing set_with_restore() size-mismatch crashes. Crash error message during 3MF import as project: <img width="833" height="274" alt="image" src="https://github.com/user-attachments/assets/f92148a9-98c6-47b7-a0ab-d5ac8b1f2be4" /> 3MF attached that causes the bug. [cube.3mf.zip](https://github.com/user-attachments/files/25318309/cube.3mf.zip)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize printer_options_with_variant_2 (stride=2) machine limit vectors during preset merge to handle legacy 3MF/projects that store only a single (normal,silent) pair despite multiple printer variants, preventing set_with_restore() size-mismatch crashes.
Crash error message during 3MF import as project:
3MF attached that causes the bug.
cube.3mf.zip