Fix filament profile import if inherit from vendor generic#11398
Merged
Conversation
to properly handle renamed system profiles
dbaarda
pushed a commit
to dbaarda/OrcaSlicer
that referenced
this pull request
Nov 27, 2025
* main: (272 commits) Delete validate-documentation.yml (OrcaSlicer#11477) Update printer profiles for Artillery (OrcaSlicer#11284) Fix emulated spiral Z-hop XY offset on multi-plate slicing (OrcaSlicer#11468) Move WIKI to new repo Validate invalid fields for hidden system profiles (OrcaSlicer#11455) ci: Increase timeout for dedupe-issues workflow from 10 to 30 minutes Fix CICD AI dedupe Change runner from self-hosted to ubuntu-latest Check duplicated issues. ported from Claude code repo (OrcaSlicer#11454) UI fixes / improvements (OrcaSlicer#11413) Fix Spiral Z-Hop arc handling (OrcaSlicer#11430) FIX: Open provided file at startup (OrcaSlicer#11419) Re-include BBS's Clipperutils2 (OrcaSlicer#11415) Fix filament profile import if inherit from vendor generic (OrcaSlicer#11398) Fix crash after syncing printer (OrcaSlicer#11428) Wiki 16 (MiniUpdate): Updated by Stable cmake 4.2 release + VS2026 First (OrcaSlicer#11423) Revert "fix GITHUB_TOKEN permissions in workflows (OrcaSlicer#11392)" correct oversight in OrcaSlicer#11392 (OrcaSlicer#11404) Profiles for Creality K2 Pro printer (OrcaSlicer#11315) Reduce artifacts from short travel moves before external perimeters (OrcaSlicer#10722) ...
dbaarda
pushed a commit
to dbaarda/OrcaSlicer
that referenced
this pull request
Dec 1, 2025
* upd-eigen-5.0.0: (273 commits) Delete validate-documentation.yml (OrcaSlicer#11477) Update printer profiles for Artillery (OrcaSlicer#11284) Fix emulated spiral Z-hop XY offset on multi-plate slicing (OrcaSlicer#11468) Move WIKI to new repo Validate invalid fields for hidden system profiles (OrcaSlicer#11455) ci: Increase timeout for dedupe-issues workflow from 10 to 30 minutes Fix CICD AI dedupe Change runner from self-hosted to ubuntu-latest Check duplicated issues. ported from Claude code repo (OrcaSlicer#11454) UI fixes / improvements (OrcaSlicer#11413) Fix Spiral Z-Hop arc handling (OrcaSlicer#11430) FIX: Open provided file at startup (OrcaSlicer#11419) Re-include BBS's Clipperutils2 (OrcaSlicer#11415) Fix filament profile import if inherit from vendor generic (OrcaSlicer#11398) Fix crash after syncing printer (OrcaSlicer#11428) Wiki 16 (MiniUpdate): Updated by Stable cmake 4.2 release + VS2026 First (OrcaSlicer#11423) Revert "fix GITHUB_TOKEN permissions in workflows (OrcaSlicer#11392)" correct oversight in OrcaSlicer#11392 (OrcaSlicer#11404) Profiles for Creality K2 Pro printer (OrcaSlicer#11315) Reduce artifacts from short travel moves before external perimeters (OrcaSlicer#10722) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've merged most of the vendor specific generic filaments (such as
Voron Generic ABS) into OrcaFilamentLibrary, and if user has custom filament profile that inherits from those, it will fail when try to import it because the parent profile no longer exist.This PR fix this issue by using
find_preset2which handle this properly.Test profile:
Voron PolyMaker ABS.json
If you try to import it in 2.3.0 and onwards it fails with the following error:
This PR:
