Fix float number not working properly for option min/max#11211
Merged
igiannakas merged 6 commits intoDec 31, 2025
Conversation
Noisyfox
force-pushed
the
bugfox/fuzzy-skin-point-distance
branch
from
1858227 to
63b7582
Compare
Collaborator
|
Looking good thank you! Lets merge. |
igiannakas
added a commit
that referenced
this pull request
Dec 31, 2025
)" This reverts commit 69861b5.
igiannakas
added a commit
that referenced
this pull request
Dec 31, 2025
Collaborator
|
Reverting as causing crash on open. Apologies, missed this as tested an older build. Need to investigate why. |
igiannakas
pushed a commit
to igiannakas/OrcaSlicer
that referenced
this pull request
Jan 2, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
RF47
pushed a commit
to RF47/OrcaSlicer
that referenced
this pull request
Jan 11, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
RF47
pushed a commit
to RF47/OrcaSlicer
that referenced
this pull request
Jan 11, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
RF47
pushed a commit
to RF47/OrcaSlicer
that referenced
this pull request
Jan 11, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss Fix nil not in range
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 11, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 13, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
RF47
pushed a commit
to RF47/OrcaSlicer
that referenced
this pull request
Jan 13, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss Fix nil not in range
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 13, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 13, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 14, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 14, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 22, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 22, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 24, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 24, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 26, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 26, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 26, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 27, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 27, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 27, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 28, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 28, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 28, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 28, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 28, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 28, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 28, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Jan 30, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 1, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 2, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 2, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 2, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 3, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 3, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 4, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 5, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 5, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 5, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 6, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Feb 6, 2026
…11211) * ConfigOptionDef: min/max values type are changed from INT to FLOAT. (cherry picked from commit f277bc8) * Fix infinite loop and crash when `fuzzy_skin_point_distance` = 0 (OrcaSlicer#11069) * Fix Linux build issue * Fix float comparison due to precision loss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopted from prusa3d/PrusaSlicer@f277bc8, thanks Prusa!
Also set min value of
fuzzy_skin_point_distanceto 0.01, because 0 will cause infinite loop & OOM.Fix #11069