Fix: A proper handling of the support_base_pattern_spacing = 0 for the Tree Slim support#11084
Merged
SoftFever merged 2 commits intoOct 20, 2025
Conversation
…the `Tree Slim` support Fixes OrcaSlicer#11082 Slicing is going to the endless loop when the `Base pattern spacing` value is 0 for `Tree Slim` support.
valerii-bokhan
force-pushed
the
support-base-pattern-spacing-zero-value-handling-fix
branch
from
a263ea8 to
a00a51e
Compare
Contributor
Author
|
@SoftFever @Noisyfox Hey, sorry for poking you directly. It's a super small PR to review, literally one line bugfix. |
SoftFever
approved these changes
Oct 20, 2025
SoftFever
left a comment
SoftFever
left a comment
Collaborator
There was a problem hiding this comment.
Very nice fix
Thank you!
valerii-bokhan
deleted the
support-base-pattern-spacing-zero-value-handling-fix
branch
dbaarda
pushed a commit
to dbaarda/OrcaSlicer
that referenced
this pull request
Oct 20, 2025
* main: (21 commits) Add Coex 3D filament profiles to Orcaslicer (OrcaSlicer#10924) Fix Z offset for 1st layer (OrcaSlicer#11011) Feature: Ability to change flow ratios by extrusion path types (Code + Docs) (OrcaSlicer#10641) Fix: A proper handling of the `support_base_pattern_spacing = 0` for the `Tree Slim` support (OrcaSlicer#11084) Limit Shrinkage values (OrcaSlicer#10930) Set Ironing angle setting to be a relative degree offset from top surface infill direction (OrcaSlicer#10841) Input Shaping Calib: Types, RepRap + Improvements (OrcaSlicer#10913) Wiki 13: Layer time variability + Minor Improvements (OrcaSlicer#10677) Validation Action comment Remove + Improvement (OrcaSlicer#10617) Material Type standarization + Technical Filament Types (OrcaSlicer#10553) Optimize and simplify MarchingSquares.hpp. (OrcaSlicer#10747) Fix several imgui UTF8 related issues (OrcaSlicer#11078) Make top resizing grabber larger on Windows (OrcaSlicer#11023) Preferences dialog redesign / improvements / fixes (OrcaSlicer#10665) Add the u8 marker to UTF-8 strings (OrcaSlicer#10666) Add static assert for bed number related values (OrcaSlicer#11035) BUG-FIX avoid crossing perimeters ingonore holes <=2mm (OrcaSlicer#10942) [Profiles] Fix Prusa XL overhang speed (OrcaSlicer#10931) (OrcaSlicer#10933) overflow inital setup screen (OrcaSlicer#11007) Clarify warning about malicious websites ...
dbaarda
pushed a commit
to dbaarda/OrcaSlicer
that referenced
this pull request
Oct 21, 2025
* opt-filltpmsfk: (21 commits) Add Coex 3D filament profiles to Orcaslicer (OrcaSlicer#10924) Fix Z offset for 1st layer (OrcaSlicer#11011) Feature: Ability to change flow ratios by extrusion path types (Code + Docs) (OrcaSlicer#10641) Fix: A proper handling of the `support_base_pattern_spacing = 0` for the `Tree Slim` support (OrcaSlicer#11084) Limit Shrinkage values (OrcaSlicer#10930) Set Ironing angle setting to be a relative degree offset from top surface infill direction (OrcaSlicer#10841) Input Shaping Calib: Types, RepRap + Improvements (OrcaSlicer#10913) Wiki 13: Layer time variability + Minor Improvements (OrcaSlicer#10677) Validation Action comment Remove + Improvement (OrcaSlicer#10617) Material Type standarization + Technical Filament Types (OrcaSlicer#10553) Optimize and simplify MarchingSquares.hpp. (OrcaSlicer#10747) Fix several imgui UTF8 related issues (OrcaSlicer#11078) Make top resizing grabber larger on Windows (OrcaSlicer#11023) Preferences dialog redesign / improvements / fixes (OrcaSlicer#10665) Add the u8 marker to UTF-8 strings (OrcaSlicer#10666) Add static assert for bed number related values (OrcaSlicer#11035) BUG-FIX avoid crossing perimeters ingonore holes <=2mm (OrcaSlicer#10942) [Profiles] Fix Prusa XL overhang speed (OrcaSlicer#10931) (OrcaSlicer#10933) overflow inital setup screen (OrcaSlicer#11007) Clarify warning about malicious websites ...
valerii-bokhan
added a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Oct 22, 2025
…the `Tree Slim` support (OrcaSlicer#11084) Fixes OrcaSlicer#11082 Slicing is going to the endless loop when the `Base pattern spacing` value is 0 for `Tree Slim` support. Co-authored-by: SoftFever <[email protected]>
valerii-bokhan
added a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Oct 22, 2025
…the `Tree Slim` support (OrcaSlicer#11084) Fixes OrcaSlicer#11082 Slicing is going to the endless loop when the `Base pattern spacing` value is 0 for `Tree Slim` support. Co-authored-by: SoftFever <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11082
Slicing is going to the endless loop when the
Base pattern spacingvalue is 0 forTree Slimsupport.The base value of the
support_base_pattern_spacingsetting was used in the support infill spacing calculation instead of the precalculated variable.Screenshots/Recordings/Graphs
Tests
Tested by generating Tree Slim supports with the
Base pattern spacingbeing0- it's not causing hangs of the slicer anymore.