bugfix for Invalid speed "G1 F-2147483648"#10944
Merged
Noisyfox merged 1 commit intoOct 12, 2025
Merged
Conversation
discip
added a commit
to discip/OrcaSlicer
that referenced
this pull request
Oct 13, 2025
* Bump actions/stale from 9 to 10 (OrcaSlicer#10919) Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/github-script from 7 to 8 (OrcaSlicer#10920) Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-python from 5 to 6 (OrcaSlicer#10921) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump tj-actions/changed-files from 46 to 47 (OrcaSlicer#10922) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 46 to 47. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v46...v47) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-version: '47' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Attempt to get the correct PR commit hash (OrcaSlicer#10900) * Attempt to get the correct PR commit hash * Add commit hash to flatpak * Use given hash if `git_commit_hash` env variable is present * bugfix for Invalid speed "G1 F-2147483648" (OrcaSlicer#10944) added non zero safety check for feedrate calculation * Clarify warning about malicious websites * overflow inital setup screen (OrcaSlicer#11007) allow overflow on setup Co-authored-by: Noisyfox <[email protected]> * [Profiles] Fix Prusa XL overhang speed (OrcaSlicer#10931) (OrcaSlicer#10933) Fix reverse order of overhangs slowdown settings * Delete .github/workflows/assign.yml * Delete .github/workflows/orca_bot.yml * Update build_all.yml --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Noisyfox <[email protected]> Co-authored-by: Azi <[email protected]> Co-authored-by: SoftFever <[email protected]> Co-authored-by: Daazed McFarland <[email protected]> Co-authored-by: Aleksandra M <[email protected]>
discip
added a commit
to discip/OrcaSlicer
that referenced
this pull request
Oct 13, 2025
* Bump actions/stale from 9 to 10 (OrcaSlicer#10919) Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/github-script from 7 to 8 (OrcaSlicer#10920) Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-python from 5 to 6 (OrcaSlicer#10921) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump tj-actions/changed-files from 46 to 47 (OrcaSlicer#10922) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 46 to 47. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v46...v47) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-version: '47' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Attempt to get the correct PR commit hash (OrcaSlicer#10900) * Attempt to get the correct PR commit hash * Add commit hash to flatpak * Use given hash if `git_commit_hash` env variable is present * bugfix for Invalid speed "G1 F-2147483648" (OrcaSlicer#10944) added non zero safety check for feedrate calculation * Clarify warning about malicious websites * overflow inital setup screen (OrcaSlicer#11007) allow overflow on setup Co-authored-by: Noisyfox <[email protected]> * [Profiles] Fix Prusa XL overhang speed (OrcaSlicer#10931) (OrcaSlicer#10933) Fix reverse order of overhangs slowdown settings * Delete .github/workflows/assign.yml * Delete .github/workflows/orca_bot.yml * Update build_all.yml * BUG-FIX avoid crossing perimeters ingonore holes <=2mm (OrcaSlicer#10942) Fix avoid crossing perimeters 2 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Noisyfox <[email protected]> Co-authored-by: Azi <[email protected]> Co-authored-by: SoftFever <[email protected]> Co-authored-by: Daazed McFarland <[email protected]> Co-authored-by: Aleksandra M <[email protected]> Co-authored-by: Rodrigo Faselli <[email protected]>
kesor
pushed a commit
to kesor/SuperSlicer
that referenced
this pull request
Nov 21, 2025
added non zero safety check for feedrate calculation Source: OrcaSlicer commit 6feb9 Original PR: OrcaSlicer/OrcaSlicer#10944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10498, also might be same issue in #2067
Added non-zero safety check for feedrate calculation in slow_down_proportional and slowdown_to_minimum_feedrate.
In CoolingBuffer::process_layer sometimes we get 2 identical gcode line:
G1 F15000;_EXTRUDE_SET_SPEED G1 F15000;_EXTRUDE_SET_SPEEDThis causes calculate_layer_slowdown to produce lines with -nan(ind) feedrate and results in G1 F-2147483648
Tests
invalid_gcod_line_test.zip
