Input Shaping Calib: Types, RepRap + Improvements#10913
Conversation
8abe982 to
7a4b036
Compare
|
you can create a note / warning instead adding description to every radio item for RepRap |
mmmm, yes i think im gonna do that and remove the dual string thing.
will check it |
So, I've done the best I could without overcomplicating things. |
353a94a to
587917b
Compare
|
Looks a lot better! One suggestion I have would be to include an
|
Co-Authored-By: yw4z <[email protected]>
Co-Authored-By: gregmatic <[email protected]>
Update Images Improve guide Co-Authored-By: Cameron D <[email protected]>
SoftFever
left a comment
There was a problem hiding this comment.
Overall, it looks good to me.
Thank you for enhancing this calibration 👍
I made some fixes and minor changes; please let me know if you think any of them were incorrect.
If everything looks good, we can proceed with the merge.
It's perfect, thanks for the review and change it directly. I'm not at home and this make the process a lot faster. |
* main: (21 commits) Add Coex 3D filament profiles to Orcaslicer (OrcaSlicer#10924) Fix Z offset for 1st layer (OrcaSlicer#11011) Feature: Ability to change flow ratios by extrusion path types (Code + Docs) (OrcaSlicer#10641) Fix: A proper handling of the `support_base_pattern_spacing = 0` for the `Tree Slim` support (OrcaSlicer#11084) Limit Shrinkage values (OrcaSlicer#10930) Set Ironing angle setting to be a relative degree offset from top surface infill direction (OrcaSlicer#10841) Input Shaping Calib: Types, RepRap + Improvements (OrcaSlicer#10913) Wiki 13: Layer time variability + Minor Improvements (OrcaSlicer#10677) Validation Action comment Remove + Improvement (OrcaSlicer#10617) Material Type standarization + Technical Filament Types (OrcaSlicer#10553) Optimize and simplify MarchingSquares.hpp. (OrcaSlicer#10747) Fix several imgui UTF8 related issues (OrcaSlicer#11078) Make top resizing grabber larger on Windows (OrcaSlicer#11023) Preferences dialog redesign / improvements / fixes (OrcaSlicer#10665) Add the u8 marker to UTF-8 strings (OrcaSlicer#10666) Add static assert for bed number related values (OrcaSlicer#11035) BUG-FIX avoid crossing perimeters ingonore holes <=2mm (OrcaSlicer#10942) [Profiles] Fix Prusa XL overhang speed (OrcaSlicer#10931) (OrcaSlicer#10933) overflow inital setup screen (OrcaSlicer#11007) Clarify warning about malicious websites ...
* opt-filltpmsfk: (21 commits) Add Coex 3D filament profiles to Orcaslicer (OrcaSlicer#10924) Fix Z offset for 1st layer (OrcaSlicer#11011) Feature: Ability to change flow ratios by extrusion path types (Code + Docs) (OrcaSlicer#10641) Fix: A proper handling of the `support_base_pattern_spacing = 0` for the `Tree Slim` support (OrcaSlicer#11084) Limit Shrinkage values (OrcaSlicer#10930) Set Ironing angle setting to be a relative degree offset from top surface infill direction (OrcaSlicer#10841) Input Shaping Calib: Types, RepRap + Improvements (OrcaSlicer#10913) Wiki 13: Layer time variability + Minor Improvements (OrcaSlicer#10677) Validation Action comment Remove + Improvement (OrcaSlicer#10617) Material Type standarization + Technical Filament Types (OrcaSlicer#10553) Optimize and simplify MarchingSquares.hpp. (OrcaSlicer#10747) Fix several imgui UTF8 related issues (OrcaSlicer#11078) Make top resizing grabber larger on Windows (OrcaSlicer#11023) Preferences dialog redesign / improvements / fixes (OrcaSlicer#10665) Add the u8 marker to UTF-8 strings (OrcaSlicer#10666) Add static assert for bed number related values (OrcaSlicer#11035) BUG-FIX avoid crossing perimeters ingonore holes <=2mm (OrcaSlicer#10942) [Profiles] Fix Prusa XL overhang speed (OrcaSlicer#10931) (OrcaSlicer#10933) overflow inital setup screen (OrcaSlicer#11007) Clarify warning about malicious websites ...
* IS Freq duplicated as Base * IS jerk to 5 * JD jerk to 0 * Base 1 layer + MINIMUM_CRUISE_RATIO=0 * Tab * Remove IS BASE * Update Plater.cpp * Klipper Jerk 5, Others 10 * JD in Marlin2 * Types * Horizontal * Different lists * RepRap IS writer * Smart Flavors and axis * RepRap values lowercase * Hide Y axix for RepRap * Max Jerk or JD * Reorder * Removed dual list + Default * RepRap show UpperCase use LowerCase * RepRap P"type" Type of input shaping to use, not case sensitive. * RepRap DAA * Reorder Klipper * Custom Firmware Note * Better Display Co-Authored-By: yw4z <[email protected]> * Better notes * Update + Clean Wiki Co-Authored-By: gregmatic <[email protected]> * Wiki Update Update Images Improve guide Co-Authored-By: Cameron D <[email protected]> * Fix G-code generation issue and refine input shaping calibration documentation --------- Co-authored-by: yw4z <[email protected]> Co-authored-by: gregmatic <[email protected]> Co-authored-by: Cameron D <[email protected]> Co-authored-by: SoftFever <[email protected]>
* IS Freq duplicated as Base * IS jerk to 5 * JD jerk to 0 * Base 1 layer + MINIMUM_CRUISE_RATIO=0 * Tab * Remove IS BASE * Update Plater.cpp * Klipper Jerk 5, Others 10 * JD in Marlin2 * Types * Horizontal * Different lists * RepRap IS writer * Smart Flavors and axis * RepRap values lowercase * Hide Y axix for RepRap * Max Jerk or JD * Reorder * Removed dual list + Default * RepRap show UpperCase use LowerCase * RepRap P"type" Type of input shaping to use, not case sensitive. * RepRap DAA * Reorder Klipper * Custom Firmware Note * Better Display Co-Authored-By: yw4z <[email protected]> * Better notes * Update + Clean Wiki Co-Authored-By: gregmatic <[email protected]> * Wiki Update Update Images Improve guide Co-Authored-By: Cameron D <[email protected]> * Fix G-code generation issue and refine input shaping calibration documentation --------- Co-authored-by: yw4z <[email protected]> Co-authored-by: gregmatic <[email protected]> Co-authored-by: Cameron D <[email protected]> Co-authored-by: SoftFever <[email protected]>
* IS Freq duplicated as Base * IS jerk to 5 * JD jerk to 0 * Base 1 layer + MINIMUM_CRUISE_RATIO=0 * Tab * Remove IS BASE * Update Plater.cpp * Klipper Jerk 5, Others 10 * JD in Marlin2 * Types * Horizontal * Different lists * RepRap IS writer * Smart Flavors and axis * RepRap values lowercase * Hide Y axix for RepRap * Max Jerk or JD * Reorder * Removed dual list + Default * RepRap show UpperCase use LowerCase * RepRap P"type" Type of input shaping to use, not case sensitive. * RepRap DAA * Reorder Klipper * Custom Firmware Note * Better Display Co-Authored-By: yw4z <[email protected]> * Better notes * Update + Clean Wiki Co-Authored-By: gregmatic <[email protected]> * Wiki Update Update Images Improve guide Co-Authored-By: Cameron D <[email protected]> * Fix G-code generation issue and refine input shaping calibration documentation --------- Co-authored-by: yw4z <[email protected]> Co-authored-by: gregmatic <[email protected]> Co-authored-by: Cameron D <[email protected]> Co-authored-by: SoftFever <[email protected]>
Description
Added Input Shaping Types to the calibration + RepRap compatibility.
Now the Dlg detects the flavor (see known issues) and use the correct type list or values to ask for.
Aiming to add what @gregmatic saids in this comment
Add Input Shaper Types
Improve Variables:
SET_VELOCITY_LIMIT MINIMUM_CRUISE_RATIO=0at first layer of testIncreased Accel to use Max of the motion ability or 20.000
Step 0: Not added, read below.
Update Wiki
Need someone to test the GUI on mac
RepRap theorical implementation (need someone actually testing it)
About Step 0:
I don't think it's important to use an increasing acceleration tower. Using a high acceleration triggers vibrations, so I increased the default acceleration to 20,000. This value will be limited by the maximum acceleration value set in the machine profile (in Motion Ability).
Known issues:
Future
I want to add the IS values to the Machine profile but i want to get SoftFever OK before to code it.
Images