Disable smooth sprial in input_shaping calibrations#10748
Merged
SoftFever merged 2 commits intoSep 28, 2025
Conversation
discip
reviewed
Sep 15, 2025
| This produces the smoothest possible spiral print. | ||
|
|
||
| > [!NOTE] | ||
| > If you are using absolute e distances, the smoothing may not work as expected. |
Contributor
There was a problem hiding this comment.
Please correct me if my assumption is wrong, but shouldn't this be:
Suggested change
| > If you are using absolute e distances, the smoothing may not work as expected. | |
| > If you are using absolute e distances, smoothing will be disabled. |
Collaborator
Author
There was a problem hiding this comment.
I didn't add any logic for that. I just disable the option for the Calibrations tests.
ianalexis
changed the title
Causes problems when using absolute distances (use_relative_e_distances = false).
ianalexis
force-pushed
the
E-absolute-no-smooth-spiral
branch
from
1139a39 to
2f898d1
Compare
SoftFever
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10474
There is apparently a bug when using smooth spiral with absolute distances (use_relative_e_distances = false).
This PR includes:
Alternatively, use_relative_e_distances could be set equal to spiral_mode_smooth
Before
After
