Skip to content

Fixes 999 CMake Warnings#10729

Merged
SoftFever merged 2 commits into
OrcaSlicer:mainfrom
rubienr:fixes-warnings-part7
Sep 19, 2025
Merged

Fixes 999 CMake Warnings#10729
SoftFever merged 2 commits into
OrcaSlicer:mainfrom
rubienr:fixes-warnings-part7

Conversation

@rubienr

@rubienr rubienr commented Sep 14, 2025

Copy link
Copy Markdown
Contributor

Description

This PR:

  • Fixes Reduce Compiler Warnings #10652
  • Fixes 999 cmake warnings:
    • fixes: 999 CMake Warnings at src/dev-utils/CMakeLists.txt:39 (add_custom_command)
    • cmake clenup: adds PUBLIC/PRIVATE to libslic3r; attempt to reduce warnigns from eigen

@rubienr rubienr force-pushed the fixes-warnings-part7 branch from 8ee032b to 39e8bb2 Compare September 16, 2025 20:31

@SoftFever SoftFever left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you!

@SoftFever SoftFever merged commit c228ab2 into OrcaSlicer:main Sep 19, 2025
12 checks passed
@rubienr

rubienr commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

You are welcome! 😃

@rubienr rubienr deleted the fixes-warnings-part7 branch September 19, 2025 17:19
dbaarda pushed a commit to dbaarda/OrcaSlicer that referenced this pull request Sep 21, 2025
* main:
  Shellcheck everything (OrcaSlicer#10730)
  Update Anycubic Kobra 2 Neo machine profile fine tune end gcode (OrcaSlicer#10742)
  Update TURKISH translations (V2.3.1-beta) (OrcaSlicer#10726)
  Fixes 999 CMake Warnings (OrcaSlicer#10729)
  Fixes 50 Compiler Warnings: Add SYSTEM toCMakeLists.txt (OrcaSlicer#10653)
  Fix variable name comment and message (OrcaSlicer#10302)
  Reflect swapped mouse buttons in Help → Keyboard Shortcuts (OrcaSlicer#10647)
  [Profile]parameters modified in printer file (OrcaSlicer#10394)
dbaarda pushed a commit to dbaarda/OrcaSlicer that referenced this pull request Sep 21, 2025
* opt-marchsq:
  Shellcheck everything (OrcaSlicer#10730)
  Update Anycubic Kobra 2 Neo machine profile fine tune end gcode (OrcaSlicer#10742)
  Update TURKISH translations (V2.3.1-beta) (OrcaSlicer#10726)
  Fixes 999 CMake Warnings (OrcaSlicer#10729)
  Fixes 50 Compiler Warnings: Add SYSTEM toCMakeLists.txt (OrcaSlicer#10653)
  Fix variable name comment and message (OrcaSlicer#10302)
  Reflect swapped mouse buttons in Help → Keyboard Shortcuts (OrcaSlicer#10647)
  [Profile]parameters modified in printer file (OrcaSlicer#10394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce Compiler Warnings

2 participants