Ignore the precise outer wall option when the wall sequence is not set to InnerOuter.#10687
Merged
Merged
Conversation
Merged
SoftFever
deleted the
feature/ignore-precise_wall_for_non_inner-outer
branch
| loop_number = 0; | ||
|
|
||
| auto apply_precise_outer_wall = config->precise_outer_wall; | ||
| auto apply_precise_outer_wall = config->precise_outer_wall && config->wall_sequence != WallSequence::InnerOuter; |
Contributor
There was a problem hiding this comment.
Should it be config->wall_sequence == WallSequence::InnerOuter; ?
Collaborator
There was a problem hiding this comment.
According to the title, yes... but even so, I don't understand why do that.
Collaborator
There was a problem hiding this comment.
This is why #10678 (comment)
So yes, it should be ==
| coord_t ext_perimeter_spacing2; | ||
| // Orca: ignore precise_outer_wall if wall_sequence is not InnerOuter | ||
| if(config->precise_outer_wall) | ||
| if(config->precise_outer_wall && config->wall_sequence != WallSequence::InnerOuter) |
Contributor
There was a problem hiding this comment.
Should it be config->wall_sequence == WallSequence::InnerOuter; ?
Collaborator
Author
There was a problem hiding this comment.
Yes, it should be ==. Thanks for pointing that out.
19 tasks
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Sep 11, 2025
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Sep 11, 2025
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Sep 11, 2025
celtare21
added a commit
to celtare21/OrcaSlicer
that referenced
this pull request
Sep 13, 2025
…s not set to InnerOuter. (OrcaSlicer#10687)" This reverts commit d2eb007.
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Sep 14, 2025
Contributor
|
Just saw this in the patch note and I don't really get it why is it disabled by default. I've read this message #10678 (comment) but on my ends, Precise Wall provides better wall surfaces even with IOI ? I mean forcing it to the user to have it disabled even though they asked it willingly for it isn't a good move imo. |
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Sep 21, 2025
celtare21
added a commit
to celtare21/OrcaSlicer
that referenced
this pull request
Sep 23, 2025
…s not set to InnerOuter. (OrcaSlicer#10687)" This reverts commit d2eb007. Signed-off-by: Kuran Kaname <[email protected]>
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Sep 29, 2025
|
I'm not particularly a fan of this PR as I have seen improved surface finish with precise wall with all wall order options, and lowers our ability to tune our printers. |
|
Didn't influence print quality on my printer with IOI but I think it's better to leave it as it was. Maybe it works on some printers? A pop up explaining it might make color painting buggy should be enough. |
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Oct 13, 2025
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Oct 15, 2025
ianalexis
added a commit
to ianalexis/OrcaSlicer
that referenced
this pull request
Oct 18, 2025
SoftFever
pushed a commit
that referenced
this pull request
Oct 19, 2025
* Layer time Variability Co-Authored-By: dewi-ny-je <[email protected]> * Layer time Variability ++ Co-Authored-By: dewi-ny-je <[email protected]> * Infill gcode analysis tool * Infill calculator project * 2 Sigma Co-Authored-By: dewi-ny-je <[email protected]> * Layer Time Variability improved calculation, grouping % and New names Co-Authored-By: dewi-ny-je <[email protected]> * Fix Applies to lines * Reorder, icons and descriptions * #10687 comment * Update phishing site reporting instructions in README README now advises users to report malicious sites using both Google Safe Browsing and Microsoft Security Intelligence, improving community security guidance. * Ziped analysis gcodes * Klipper estimator + 3mf klipperized * Klipper estimator Corrected * Reformat MD generator * extra-solid-infill.gif Size Optimized * Analysis Refactor * cleaned outliers * imagefix * Images with accurate values * Project specific Machine, Material and Process * Notes * Update extra-solid-infill.gif * Update profiles images and fix using same name * Zipped analysis files * Add note on Avoid Crossing Walls and Timelapse mode Co-Authored-By: Rodrigo <[email protected]> * Update VS build instructions Co-Authored-By: Anson Liu <[email protected]> * Added IPThreat report links in README * DEFA[.]NG Co-Authored-By: Nanashi <[email protected]> --------- Co-authored-by: dewi-ny-je <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: Anson Liu <[email protected]> Co-authored-by: Nanashi <[email protected]>
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Oct 22, 2025
* Layer time Variability Co-Authored-By: dewi-ny-je <[email protected]> * Layer time Variability ++ Co-Authored-By: dewi-ny-je <[email protected]> * Infill gcode analysis tool * Infill calculator project * 2 Sigma Co-Authored-By: dewi-ny-je <[email protected]> * Layer Time Variability improved calculation, grouping % and New names Co-Authored-By: dewi-ny-je <[email protected]> * Fix Applies to lines * Reorder, icons and descriptions * OrcaSlicer#10687 comment * Update phishing site reporting instructions in README README now advises users to report malicious sites using both Google Safe Browsing and Microsoft Security Intelligence, improving community security guidance. * Ziped analysis gcodes * Klipper estimator + 3mf klipperized * Klipper estimator Corrected * Reformat MD generator * extra-solid-infill.gif Size Optimized * Analysis Refactor * cleaned outliers * imagefix * Images with accurate values * Project specific Machine, Material and Process * Notes * Update extra-solid-infill.gif * Update profiles images and fix using same name * Zipped analysis files * Add note on Avoid Crossing Walls and Timelapse mode Co-Authored-By: Rodrigo <[email protected]> * Update VS build instructions Co-Authored-By: Anson Liu <[email protected]> * Added IPThreat report links in README * DEFA[.]NG Co-Authored-By: Nanashi <[email protected]> --------- Co-authored-by: dewi-ny-je <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: Anson Liu <[email protected]> Co-authored-by: Nanashi <[email protected]>
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Oct 22, 2025
* Layer time Variability Co-Authored-By: dewi-ny-je <[email protected]> * Layer time Variability ++ Co-Authored-By: dewi-ny-je <[email protected]> * Infill gcode analysis tool * Infill calculator project * 2 Sigma Co-Authored-By: dewi-ny-je <[email protected]> * Layer Time Variability improved calculation, grouping % and New names Co-Authored-By: dewi-ny-je <[email protected]> * Fix Applies to lines * Reorder, icons and descriptions * OrcaSlicer#10687 comment * Update phishing site reporting instructions in README README now advises users to report malicious sites using both Google Safe Browsing and Microsoft Security Intelligence, improving community security guidance. * Ziped analysis gcodes * Klipper estimator + 3mf klipperized * Klipper estimator Corrected * Reformat MD generator * extra-solid-infill.gif Size Optimized * Analysis Refactor * cleaned outliers * imagefix * Images with accurate values * Project specific Machine, Material and Process * Notes * Update extra-solid-infill.gif * Update profiles images and fix using same name * Zipped analysis files * Add note on Avoid Crossing Walls and Timelapse mode Co-Authored-By: Rodrigo <[email protected]> * Update VS build instructions Co-Authored-By: Anson Liu <[email protected]> * Added IPThreat report links in README * DEFA[.]NG Co-Authored-By: Nanashi <[email protected]> --------- Co-authored-by: dewi-ny-je <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: Anson Liu <[email protected]> Co-authored-by: Nanashi <[email protected]>
valerii-bokhan
pushed a commit
to valerii-bokhan/OrcaSlicer
that referenced
this pull request
Oct 22, 2025
* Layer time Variability Co-Authored-By: dewi-ny-je <[email protected]> * Layer time Variability ++ Co-Authored-By: dewi-ny-je <[email protected]> * Infill gcode analysis tool * Infill calculator project * 2 Sigma Co-Authored-By: dewi-ny-je <[email protected]> * Layer Time Variability improved calculation, grouping % and New names Co-Authored-By: dewi-ny-je <[email protected]> * Fix Applies to lines * Reorder, icons and descriptions * OrcaSlicer#10687 comment * Update phishing site reporting instructions in README README now advises users to report malicious sites using both Google Safe Browsing and Microsoft Security Intelligence, improving community security guidance. * Ziped analysis gcodes * Klipper estimator + 3mf klipperized * Klipper estimator Corrected * Reformat MD generator * extra-solid-infill.gif Size Optimized * Analysis Refactor * cleaned outliers * imagefix * Images with accurate values * Project specific Machine, Material and Process * Notes * Update extra-solid-infill.gif * Update profiles images and fix using same name * Zipped analysis files * Add note on Avoid Crossing Walls and Timelapse mode Co-Authored-By: Rodrigo <[email protected]> * Update VS build instructions Co-Authored-By: Anson Liu <[email protected]> * Added IPThreat report links in README * DEFA[.]NG Co-Authored-By: Nanashi <[email protected]> --------- Co-authored-by: dewi-ny-je <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: Anson Liu <[email protected]> Co-authored-by: Nanashi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Recordings/Graphs
Tests