Skip to content

Feature/fix_profiles#10678

Merged
SoftFever merged 4 commits into
mainfrom
feature/fix_profiles
Sep 10, 2025
Merged

Feature/fix_profiles#10678
SoftFever merged 4 commits into
mainfrom
feature/fix_profiles

Conversation

@SoftFever

Copy link
Copy Markdown
Collaborator

Description

Screenshots/Recordings/Graphs

Tests

@SoftFever SoftFever merged commit 5e9570c into main Sep 10, 2025
10 checks passed
@igiannakas

Copy link
Copy Markdown
Collaborator

@SoftFever this option can cause slight issues with multi colour models when printing inner outer inner wall ordering mode. It causes wall reordering to fail on occasion due to the sharp corners generated by segmentation from painting + the increased spacing in the outer wall causing it to encroach to neighbouring perimeters and fail reordering in the right way.

If we are to enable this option by default, we should create a rule to disable it when IOI is enabled - maybe a pop up in the UI?

IOI is not relevant to this option anyhow. Despite what I had done/said in the past :)

@SoftFever

Copy link
Copy Markdown
Collaborator Author

@SoftFever this option can cause slight issues with multi colour models when printing inner outer inner wall ordering mode. It causes wall reordering to fail on occasion due to the sharp corners generated by segmentation from painting + the increased spacing in the outer wall causing it to encroach to neighbouring perimeters and fail reordering in the right way.

If we are to enable this option by default, we should create a rule to disable it when IOI is enabled - maybe a pop up in the UI?

IOI is not relevant to this option anyhow. Despite what I had done/said in the past :)

Haha, I've been waiting to say this: "I told you" ;)
The option is only useful for inner-outer by design.
I will push another change to disable it when outer-inner or sandwich mode is used.

@SoftFever SoftFever deleted the feature/fix_profiles branch September 11, 2025 09:56
@igiannakas

igiannakas commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

I know I know …. 😁😆edge case but why have it 😬😁

@SoftFever

Copy link
Copy Markdown
Collaborator Author

I know I know …. 😁😆edge case but why have it 😬😁

Changed #10687

@igiannakas

Copy link
Copy Markdown
Collaborator

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants