[Profiles] Enable Arc fitting for QIDI plus4 and Q2 printers#10618
Merged
Conversation
This update introduces new consumables and a new model, Q2
SoftFever
changed the title
Collaborator
|
LGTM |
Contributor
|
Do we realise that Plus 4 has arc length set to 0.5 mm, which for small holes is TERRIBLE and much worse than the original STLs? |
Collaborator
|
I think this PR is really not a good idea. Arc fitting for Klipper is a lossy operation (lines -> arcs lossy conversion in the slicer -> back to lines by Klipper) for zero benefit. @SoftFever - FYI, they are both Klipper machines I believe. Suggest this is reverted unless there is an absolutely good reason to have arc fitting enabled for them? |
Contributor
|
See also #10626 |
|
@SoftFever Was this merged by accident without realizing these are Klipper printers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arc fitting for QIDI plus4 and Q2 has been initiated