Material Type standarization + Technical Filament Types#10553
Conversation
a715705 to
9f9b8f2
Compare
9f9b8f2 to
70ac630
Compare
050eea4 to
d2e35e7
Compare
d2e35e7 to
1f65b2c
Compare
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
530b3a1 to
eb9dbf0
Compare
|
How would you deal with something like ColorFabb PLA-LW-HT? |
Pla lw ht is something like pla foam AFAIK (correct me if I'm wrong, I didn't know about it until now). Now days what type is used for it? No matter what, probably they are not the correct ones and whit this modification it will be really easy to add them. |
|
@ianalexis it is PLA that has foaming agent added in and was further modified to resist higher temperatures. So, two modifiers which is my concern with the proposed scheme. |
8f28736 to
ce01fd8
Compare
PLA-HT changes usually impact the final piece rather than the printing parameters, so I did not consider creating an extra subtype. From what I saw in many ColorFabb posts, both (PLA-LW and PLA-LW-HT) fall perfectly within the PLA-FOAM range. The differences between the two lie in the definition of each profile (such as first layer temperature, bed temperature, and flow coefficients), but the base type should be PLA-FOAM. |
98bf715 to
ff1b285
Compare
Separates minimum and maximum recommended temperature warnings for nozzle configuration + generig °c usage. Co-Authored-By: Alexandre Folle de Menezes <[email protected]>
Co-Authored-By: Rodrigo <[email protected]>
options.
Introduces get_filament_chamber_temp_range to retrieve safe chamber temperature limits for filament types. Updates ConfigManipulation to use these limits instead of hardcoded values.
Replaces hardcoded material checks for adhesion coefficient and yield strength with lookup functions using extended FilamentType struct.
Moved filament type properties and related lookup functions from PrintConfig.cpp into a new MaterialType class.
ff1b285 to
84c64bd
Compare
Co-Authored-By: SoftFever <[email protected]>
|
LGTM |
* main: (21 commits) Add Coex 3D filament profiles to Orcaslicer (OrcaSlicer#10924) Fix Z offset for 1st layer (OrcaSlicer#11011) Feature: Ability to change flow ratios by extrusion path types (Code + Docs) (OrcaSlicer#10641) Fix: A proper handling of the `support_base_pattern_spacing = 0` for the `Tree Slim` support (OrcaSlicer#11084) Limit Shrinkage values (OrcaSlicer#10930) Set Ironing angle setting to be a relative degree offset from top surface infill direction (OrcaSlicer#10841) Input Shaping Calib: Types, RepRap + Improvements (OrcaSlicer#10913) Wiki 13: Layer time variability + Minor Improvements (OrcaSlicer#10677) Validation Action comment Remove + Improvement (OrcaSlicer#10617) Material Type standarization + Technical Filament Types (OrcaSlicer#10553) Optimize and simplify MarchingSquares.hpp. (OrcaSlicer#10747) Fix several imgui UTF8 related issues (OrcaSlicer#11078) Make top resizing grabber larger on Windows (OrcaSlicer#11023) Preferences dialog redesign / improvements / fixes (OrcaSlicer#10665) Add the u8 marker to UTF-8 strings (OrcaSlicer#10666) Add static assert for bed number related values (OrcaSlicer#11035) BUG-FIX avoid crossing perimeters ingonore holes <=2mm (OrcaSlicer#10942) [Profiles] Fix Prusa XL overhang speed (OrcaSlicer#10931) (OrcaSlicer#10933) overflow inital setup screen (OrcaSlicer#11007) Clarify warning about malicious websites ...
* opt-filltpmsfk: (21 commits) Add Coex 3D filament profiles to Orcaslicer (OrcaSlicer#10924) Fix Z offset for 1st layer (OrcaSlicer#11011) Feature: Ability to change flow ratios by extrusion path types (Code + Docs) (OrcaSlicer#10641) Fix: A proper handling of the `support_base_pattern_spacing = 0` for the `Tree Slim` support (OrcaSlicer#11084) Limit Shrinkage values (OrcaSlicer#10930) Set Ironing angle setting to be a relative degree offset from top surface infill direction (OrcaSlicer#10841) Input Shaping Calib: Types, RepRap + Improvements (OrcaSlicer#10913) Wiki 13: Layer time variability + Minor Improvements (OrcaSlicer#10677) Validation Action comment Remove + Improvement (OrcaSlicer#10617) Material Type standarization + Technical Filament Types (OrcaSlicer#10553) Optimize and simplify MarchingSquares.hpp. (OrcaSlicer#10747) Fix several imgui UTF8 related issues (OrcaSlicer#11078) Make top resizing grabber larger on Windows (OrcaSlicer#11023) Preferences dialog redesign / improvements / fixes (OrcaSlicer#10665) Add the u8 marker to UTF-8 strings (OrcaSlicer#10666) Add static assert for bed number related values (OrcaSlicer#11035) BUG-FIX avoid crossing perimeters ingonore holes <=2mm (OrcaSlicer#10942) [Profiles] Fix Prusa XL overhang speed (OrcaSlicer#10931) (OrcaSlicer#10933) overflow inital setup screen (OrcaSlicer#11007) Clarify warning about malicious websites ...
…0553) * New materials * Temps * Full filament type list * Improve nozzle temperature range validation messages Separates minimum and maximum recommended temperature warnings for nozzle configuration + generig °c usage. Co-Authored-By: Alexandre Folle de Menezes <[email protected]> * Material Updates Co-Authored-By: Rodrigo <[email protected]> * petg-cf10 should be petg-cf options. * Pla reduced range * Adjust some temps * FilamentTempType Temperature-based logic * chamber temps * Fromatting * Filament chamber temperature range support Introduces get_filament_chamber_temp_range to retrieve safe chamber temperature limits for filament types. Updates ConfigManipulation to use these limits instead of hardcoded values. * add adhesion coefficient and yield strength Replaces hardcoded material checks for adhesion coefficient and yield strength with lookup functions using extended FilamentType struct. * Thermal length * Fix * Refactor filament type data to MaterialType class Moved filament type properties and related lookup functions from PrintConfig.cpp into a new MaterialType class. * Fix adhesion_coefficient Co-Authored-By: SoftFever <[email protected]> --------- Co-authored-by: Alexandre Folle de Menezes <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: SoftFever <[email protected]>
…0553) * New materials * Temps * Full filament type list * Improve nozzle temperature range validation messages Separates minimum and maximum recommended temperature warnings for nozzle configuration + generig °c usage. Co-Authored-By: Alexandre Folle de Menezes <[email protected]> * Material Updates Co-Authored-By: Rodrigo <[email protected]> * petg-cf10 should be petg-cf options. * Pla reduced range * Adjust some temps * FilamentTempType Temperature-based logic * chamber temps * Fromatting * Filament chamber temperature range support Introduces get_filament_chamber_temp_range to retrieve safe chamber temperature limits for filament types. Updates ConfigManipulation to use these limits instead of hardcoded values. * add adhesion coefficient and yield strength Replaces hardcoded material checks for adhesion coefficient and yield strength with lookup functions using extended FilamentType struct. * Thermal length * Fix * Refactor filament type data to MaterialType class Moved filament type properties and related lookup functions from PrintConfig.cpp into a new MaterialType class. * Fix adhesion_coefficient Co-Authored-By: SoftFever <[email protected]> --------- Co-authored-by: Alexandre Folle de Menezes <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: SoftFever <[email protected]>
…0553) * New materials * Temps * Full filament type list * Improve nozzle temperature range validation messages Separates minimum and maximum recommended temperature warnings for nozzle configuration + generig °c usage. Co-Authored-By: Alexandre Folle de Menezes <[email protected]> * Material Updates Co-Authored-By: Rodrigo <[email protected]> * petg-cf10 should be petg-cf options. * Pla reduced range * Adjust some temps * FilamentTempType Temperature-based logic * chamber temps * Fromatting * Filament chamber temperature range support Introduces get_filament_chamber_temp_range to retrieve safe chamber temperature limits for filament types. Updates ConfigManipulation to use these limits instead of hardcoded values. * add adhesion coefficient and yield strength Replaces hardcoded material checks for adhesion coefficient and yield strength with lookup functions using extended FilamentType struct. * Thermal length * Fix * Refactor filament type data to MaterialType class Moved filament type properties and related lookup functions from PrintConfig.cpp into a new MaterialType class. * Fix adhesion_coefficient Co-Authored-By: SoftFever <[email protected]> --------- Co-authored-by: Alexandre Folle de Menezes <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: SoftFever <[email protected]>
Description
Note
Some "filament types" i found in some profiles that are "wrong" or not a material technical name so i didin't add them:
Posible evolution
add "modifiers" options to reduce the material list:
Result material should be [BASE MATERIAL]-[TYPE]-[Reinforcer]
But i'm not going to code this unless there is interest from @SoftFever so you choose.