[OPTIMIZATION] Update Fill3DHoneycomb.hpp - remove bridge flow#10453
Merged
Conversation
Bridge flow isn't necessary; the pattern is fully supported on the lines that matter for structural stability.
Collaborator
|
when you use multiline infill honeycomb is not fully supported, it make bridges. |
Contributor
Author
|
That looks like the wrong infill pattern. Have you chosen "3D Honeycomb"? |
Collaborator
Oh, you're right, my mistake. |
SoftFever
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridge flow isn't necessary; the pattern is fully supported on the lines that matter for structural stability.
I noticed in a recent comment for the PrusaSlicer version of this that I had forgotten to disable bridge flow for this pattern; that is now fixed.