Skip to content

Fix: export printer config skipping currently selected preset#10380

Merged
SoftFever merged 5 commits into
OrcaSlicer:mainfrom
Azio-Pantheon:fix/export-printerconfig-skipping-currently-selected-preset
Aug 21, 2025
Merged

Fix: export printer config skipping currently selected preset#10380
SoftFever merged 5 commits into
OrcaSlicer:mainfrom
Azio-Pantheon:fix/export-printerconfig-skipping-currently-selected-preset

Conversation

@Azio-Pantheon

Copy link
Copy Markdown
Contributor

Export Preset Bundle->Printer config bundle will not consider the currently selected printer as a valid option. Fixes #10327

Removed this check (preset_bundle.printers.select_preset_by_name(preset_name, false))`

Tests

Tried out the user config in the bug report. If you create and select another printer, you can get Bambu Lab P1S 0.4 nozzle to show up.

@SoftFever

SoftFever commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

Hmmm, I'm not sure if this is the right way to go.
Have you checked why the select_preset_by_name function failed?

@Azio-Pantheon

Copy link
Copy Markdown
Contributor Author

Hmmm, I'm not sure if this is the right way to go. Have you checked why the select_preset_by_name function failed?

As far as I can tell, select_preset_by_name is used to sets the "active" or "currently selected" reset, so when the currently selected preset is already the preset that select_preset_by_name is trying to set active, it just returns false and skip the preset selection this->select_preset(idx); . I do not think this method should be used in the case of exporting presets.

@Azio-Pantheon

Copy link
Copy Markdown
Contributor Author

I just found out bambu studio "fixed" it by changing (preset_bundle.printers.select_preset_by_name(preset_name, false)) to (preset_bundle.printers.select_preset_by_name(preset_name, true)) which just force it to trigger preset selection and relavant UI rendering then returns true. It also works, but I think it is unnecessary. Both options fixes the export not showing up bug. @SoftFever How would you like this to be implemented?

@SoftFever

Copy link
Copy Markdown
Collaborator

I just found out bambu studio "fixed" it by changing (preset_bundle.printers.select_preset_by_name(preset_name, false)) to (preset_bundle.printers.select_preset_by_name(preset_name, true)) which just force it to trigger preset selection and relavant UI rendering then returns true. It also works, but I think it is unnecessary. Both options fixes the export not showing up bug. @SoftFever How would you like this to be implemented?

@Azio-Pantheon
Thank you for digging into the issue.
I've reviewed this issue too. We shouldn't remove this if check because doing so would cause problems when selecting a non-current printer. The update compatibility won't work properly if we don't select the printer first.
Setting the "force" parameter to true is the correct way to resolve this issue.

@SoftFever SoftFever left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you

@SoftFever SoftFever merged commit 4981b0b into OrcaSlicer:main Aug 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot export printer filament process

2 participants