make Fuzzy skin options only available when Fuzzy skin is not disabled by discip · Pull Request #10312 · OrcaSlicer/OrcaSlicer

discip · 2025-08-02T21:22:17Z

Mimicking the behavior of Ironing.

ianalexis · 2025-08-02T23:07:11Z

I would make a bool instead of FuzzySkinType fuzzy_skin = config->opt_enum<FuzzySkinType>("fuzzy_skin"); and latter fuzzy_skin != FuzzySkinType::None
Directly bool has_fuzzy_skin = config->opt_enum<FuzzySkinType>("fuzzy_skin") != FuzzySkinType::None;
Another thing, check you added a empty line (125) in .github/workflows/build_all.yml

Noisyfox · 2025-08-03T03:33:14Z

Fuzzy skin painting. I didn't bother to check if any fuzzy painting is applied so I just show those options regardless.

discip · 2025-08-04T23:37:12Z

Is there a way to check whether Fuzzy skin painting is used?

ianalexis · 2025-08-05T00:16:09Z

I would make a bool instead

Before paint on fuzzy it was like that

Is there a way to check whether Fuzzy skin painting is used?

JUST A QUICK SEARCH IF HELPS:
Try with ModelObject::is_fuzzy_skin_painted or is_fuzzy_skin_painted
Maybe add an option "Paint only" and modify the logic with that.
https://github.com/SoftFever/OrcaSlicer/blob/f27a40d29ba3dd525dd41f94b2856827c5c6c1cf/src/libslic3r/PrintApply.cpp#L1045

@ianalexis

As suggested by @ianalexis here: OrcaSlicer#10312 (comment)

discip · 2025-08-06T18:04:24Z

@SoftFever
Unfortunately the last build doesn't work for me.
It doesn't even make it past the splash screen.
I tried both AppImage and Flatpak.

Seems to be related to has_painted_fuzzy_skin.
I'm not sure if it is the correct way of implementing that.
Any idea on what might be wrong here? 😅

thanks in advance

discip · 2025-08-08T20:42:15Z

@Noisyfox
Could you please assist with making it work with has_painted_fuzzy_skin.
I already tried to use Copilot, but it was not able to help me.

Noisyfox · 2025-08-11T03:05:26Z

There is no such option called painted_fuzzy_skin hens it didn't work. I think you need to either add an fuzzy skin mode called "painted" like what brim ear painting does; or introduce an hidden option that stores the fuzzy skin painting state, like how has_scarf_joint_seam is implemented (though I'm not sure if this could trigger the ConfigManipulation to update the UI).

Since I'm not able to include the dependency on **`Paint-on fuzzy skin`**, this is the working state for now. Maybe one of the skilled programmers could improve it by implementing that feature as well. 😊

Noisyfox · 2025-11-13T09:14:08Z

One thoughts on this: BambuStudio added a new fuzzy type (disabled), which disabled both paint on fuzzy and normal fuzzy. I think that makes hiding these options easier. Maybe we could do the same thing and don't need to worry about checking different regions/options & adding internal hidden properties etc.

discip · 2025-11-13T12:38:05Z

As you might have noticed, I'm no programmer, so I would be happy if you could take this on.
I'm thankful for every help I can get.

The fuzzy skin "None" option has been split into None (allow paint) and Disabled (disables painting). Two parameters can be adjusted in None mode, and the behavior remains the same as the original None mode. Additionally, can setting the "disable" modifier to suppress fuzzy generation within a specific area. jira: STUDIO-14114 Change-Id: I174a3ff7adac05bc0a031a90a24a03b3d7ba41e8 (cherry picked from commit d38f4dd5e7f5a842a270de35b6a17bc5c4586485)

Noisyfox · 2025-11-14T12:25:45Z

Ok I've cherry picked the changes from BBS and made necessary changes accordingly.
One more thing that I'd like to do is adding a warning message in fuzzy painting gizmo if fuzzy mode is set to disabled (similar to what we have in brim painting gizmo).

discip · 2025-11-14T12:37:49Z

Great!
Please do as you see fit.

Thank you!

discip · 2025-11-14T18:36:49Z

Just 2 more thoughts:

What about modifiers (height range, svg, ...).

Maybe the text should say Only modifiers instead of None (allow paint)?
Essentially None (allow paint) and Disabled are redundant as long as the latter does modifiers not prevent from having effect, while options are not accessible.

Noisyfox · 2025-11-15T01:32:20Z

2. Essentially None (allow paint) and Disabled are redundant as long as the latter does modifiers not prevent from having effect, while options are not accessible.

They are different, disabled act like a blocker when used with modifiers, while none means no global fuzzy but only painted on.

discip · 2025-11-26T06:28:32Z

Then this should be good to go, right. 😊

discip · 2025-12-19T05:30:53Z

    const auto fuzziy_type = config.type;

-    if (fuzziy_type == FuzzySkinType::None) {
+    if (fuzziy_type == FuzzySkinType::None|| fuzziy_type == FuzzySkinType::Disabled_fuzzy) {


@Noisyfox

Any chance fuzziy is a typo?

Suggested change

if (fuzziy_type == FuzzySkinType::None|| fuzziy_type == FuzzySkinType::Disabled_fuzzy) {

if (fuzzy_type == FuzzySkinType::None|| fuzzy_type == FuzzySkinType::Disabled_fuzzy) {

OrcaSlicer#10312) Mimicking the behavior of Ironing. ![demo](https://github.com/user-attachments/assets/443aa8c3-8b7c-4ab1-8445-4796185273d4)

OrcaSlicer/OrcaSlicer#10312 OrcaSlicer/OrcaSlicer#12479 OrcaSlicer/OrcaSlicer#12487

discip added 13 commits July 26, 2025 12:00

show options depending on whether fuzzy skin is active

87f4699

for testing purpose

68e0478

Merge branch 'SoftFever:main' into patch-1

5308cab

Update ConfigManipulation.cpp

c541b37

Merge branch 'SoftFever:main' into patch-1

0b51933

Update ConfigManipulation.cpp

d356cd2

Merge branch 'SoftFever:main' into patch-1

712ea68

Update ConfigManipulation.cpp

81823e3

Update ConfigManipulation.cpp

c9405fa

Merge branch 'SoftFever:main' into patch-1

ce314b0

Update ConfigManipulation.cpp

6a94664

Merge branch 'SoftFever:main' into patch-1

41c2bd0

Update build_all.yml

d1d50f7

discip added 5 commits August 5, 2025 13:37

Update build_all.yml

6878987

Update build_all.yml

8d8692d

Merge branch 'SoftFever:main' into patch-1

4fd3981

Update ConfigManipulation.cpp

8b7853f

As suggested by @ianalexis here: OrcaSlicer#10312 (comment)

Update ConfigManipulation.cpp

a859b0f

SoftFever requested a review from Copilot August 5, 2025 15:08

This comment was marked as outdated.

Sign in to view

Merge branch 'SoftFever:main' into patch-1

53d51be

discip added 2 commits August 11, 2025 08:36

remove dependency on has_painted_fuzzy_skin

2eb441c

Since I'm not able to include the dependency on **`Paint-on fuzzy skin`**, this is the working state for now. Maybe one of the skilled programmers could improve it by implementing that feature as well. 😊

Merge branch 'main' into patch-1

ceaac6a

Merge branch 'SoftFever:main' into patch-1

81c579b

Noisyfox and others added 4 commits November 14, 2025 19:07

Merge remote-tracking branch 'upstream/main' into patch-1

049b28a

Don't bother with fuzzy skin painting checking

36fb304

Disable fuzzy skin by default

a50fc4a

Noisyfox changed the title ~~make Fuzzy skin options only available when Fuzzy skin is enabled~~ make Fuzzy skin options only available when Fuzzy skin is not disabled Nov 14, 2025

Show warning text if fuzzy painting is disabled

36c4657

Noisyfox marked this pull request as ready for review November 14, 2025 14:39

Merge branch 'main' into patch-1

981baf9

discip added 4 commits December 9, 2025 09:06

Merge branch 'OrcaSlicer:main' into patch-1

d24bb10

Merge branch 'OrcaSlicer:main' into patch-1

830a341

Merge branch 'OrcaSlicer:main' into patch-1

0251c2d

Merge branch 'main' into patch-1

060a2cc

discip commented Dec 19, 2025

View reviewed changes

discip and others added 5 commits December 30, 2025 11:07

Merge branch 'OrcaSlicer:main' into patch-1

eba2e61

Merge branch 'OrcaSlicer:main' into patch-1

39f9df2

Merge branch 'OrcaSlicer:main' into patch-1

b670f20

Merge branch 'main' into patch-1

385c1b9

Merge branch 'main' into patch-1

49e87b2

SoftFever merged commit b37f68d into OrcaSlicer:main Jan 15, 2026
11 checks passed

ianalexis mentioned this pull request Feb 26, 2026

Fuzzy update OrcaSlicer/OrcaSlicer_WIKI#179

Merged

ianalexis added a commit to OrcaSlicer/OrcaSlicer_WIKI that referenced this pull request May 8, 2026

Fuzzy update (#179)

10e3733

OrcaSlicer/OrcaSlicer#10312 OrcaSlicer/OrcaSlicer#12479 OrcaSlicer/OrcaSlicer#12487

	if (fuzziy_type == FuzzySkinType::None\|\| fuzziy_type == FuzzySkinType::Disabled_fuzzy) {
	if (fuzzy_type == FuzzySkinType::None\|\| fuzzy_type == FuzzySkinType::Disabled_fuzzy) {

Uh oh!

Conversation

discip commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ianalexis commented Aug 2, 2025

Uh oh!

Noisyfox commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

discip commented Aug 4, 2025

Uh oh!

ianalexis commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

discip commented Aug 6, 2025

Uh oh!

discip commented Aug 8, 2025

Uh oh!

Noisyfox commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Noisyfox commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

discip commented Nov 13, 2025

Uh oh!

Noisyfox commented Nov 14, 2025

Uh oh!

discip commented Nov 14, 2025

Uh oh!

discip commented Nov 14, 2025

Uh oh!

Noisyfox commented Nov 15, 2025

Uh oh!

discip commented Nov 26, 2025

Uh oh!

discip Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

discip commented Aug 2, 2025 •

edited

Loading

Noisyfox commented Aug 3, 2025 •

edited

Loading

ianalexis commented Aug 5, 2025 •

edited

Loading

Noisyfox commented Aug 11, 2025 •

edited

Loading

Noisyfox commented Nov 13, 2025 •

edited

Loading