Skip to content

Make Ownable's initial owner explicit#4267

Merged
frangio merged 5 commits intoOpenZeppelin:next-v5.0from
Amxx:next/initial-owner
May 23, 2023
Merged

Make Ownable's initial owner explicit#4267
frangio merged 5 commits intoOpenZeppelin:next-v5.0from
Amxx:next/initial-owner

Conversation

@Amxx
Copy link
Copy Markdown
Collaborator

@Amxx Amxx commented May 22, 2023

Fixes #2639
Fixes LIB-835

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: fbb7e70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx changed the base branch from master to next-v5.0 May 22, 2023 08:09
@socket-security
Copy link
Copy Markdown

socket-security bot commented May 22, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Critical CVE ✅ 0 issues
CVE ✅ 0 issues
Mild CVE ✅ 0 issues
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] None +0 ljharb

@Amxx Amxx requested review from ernestognw and frangio May 22, 2023 08:09
ernestognw
ernestognw previously approved these changes May 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Just a minor nit in the format of the changelog, I think it's more consisten with what we've done

frangio
frangio approved these changes May 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio merged commit 13d5e04 into OpenZeppelin:next-v5.0 May 23, 2023
@Amxx Amxx deleted the next/initial-owner branch May 24, 2023 07:36
@Amxx Amxx mentioned this pull request Jun 8, 2023
Closed
@nxt3d nxt3d mentioned this pull request Jun 19, 2023
Closed
@shaspitz shaspitz mentioned this pull request Nov 7, 2023
Merged
@YouStillAlive YouStillAlive mentioned this pull request May 7, 2024
Merged
This was referenced Jun 15, 2024
Open
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
This was referenced Jul 9, 2024
Open
Open
This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@RomulousApollo RomulousApollo mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 12, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 8, 2024
Open
Open
This was referenced Nov 9, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frangio frangio frangio approved these changes

@ernestognw ernestognw ernestognw left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ownable should support setting the initial owner through its constructor

3 participants

@Amxx @frangio @ernestognw